You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2015/09/15 08:03:15 UTC
[10/50] [abbrv] isis git commit: ISIS-1194: simplifying logging in
IsisLifecycleListener2
ISIS-1194: simplifying logging in IsisLifecycleListener2
Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/6243d524
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/6243d524
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/6243d524
Branch: refs/heads/master
Commit: 6243d5248175bdcbc498b6e851f20896a5cd3393
Parents: 1d5431a
Author: Dan Haywood <da...@haywood-associates.co.uk>
Authored: Fri Sep 11 18:52:48 2015 +0100
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Mon Sep 14 07:36:02 2015 +0100
----------------------------------------------------------------------
.../persistence/IsisLifecycleListener2.java | 36 +++++++++-----------
1 file changed, 16 insertions(+), 20 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/isis/blob/6243d524/core/runtime/src/main/java/org/apache/isis/core/runtime/system/persistence/IsisLifecycleListener2.java
----------------------------------------------------------------------
diff --git a/core/runtime/src/main/java/org/apache/isis/core/runtime/system/persistence/IsisLifecycleListener2.java b/core/runtime/src/main/java/org/apache/isis/core/runtime/system/persistence/IsisLifecycleListener2.java
index d40a238..68a966a 100644
--- a/core/runtime/src/main/java/org/apache/isis/core/runtime/system/persistence/IsisLifecycleListener2.java
+++ b/core/runtime/src/main/java/org/apache/isis/core/runtime/system/persistence/IsisLifecycleListener2.java
@@ -56,58 +56,58 @@ public class IsisLifecycleListener2
@Override
public void postCreate(final InstanceLifecycleEvent event) {
- withLogging(new RunnableNoop(event));
+ new RunnableNoop(event).run();
}
@Override
public void preAttach(final InstanceLifecycleEvent event) {
- withLogging(new RunnableEnsureRootObject(event));
+ new RunnableEnsureRootObject(event).run();
}
@Override
public void postAttach(final InstanceLifecycleEvent event) {
- withLogging(new RunnableEnsureRootObject(event));
+ new RunnableEnsureRootObject(event).run();
}
@Override
public void postLoad(final InstanceLifecycleEvent event) {
- withLogging(new RunnableAbstract(event){
+ new RunnableAbstract(event){
@Override
protected void doRun() {
final Persistable pojo = Utils.persistenceCapableFor(event);
persistenceSession.initializeMapAndCheckConcurrency(pojo);
- }});
+ }}.run();
}
@Override
public void preStore(InstanceLifecycleEvent event) {
- withLogging(new RunnableAbstract(event){
+ new RunnableAbstract(event){
@Override
protected void doRun() {
final Persistable pojo = Utils.persistenceCapableFor(event);
persistenceSession.invokeIsisPersistingCallback(pojo);
- }});
+ }}.run();
}
@Override
public void postStore(InstanceLifecycleEvent event) {
- withLogging(new RunnableAbstract(event){
+ new RunnableAbstract(event){
@Override
protected void doRun() {
final Persistable pojo = Utils.persistenceCapableFor(event);
persistenceSession.postStoreProcessingFor(pojo);
- }});
+ }}.run();
}
@Override
public void preDirty(InstanceLifecycleEvent event) {
- withLogging(new RunnableAbstract(event){
+ new RunnableAbstract(event){
@Override
protected void doRun() {
final Persistable pojo = Utils.persistenceCapableFor(event);
persistenceSession.preDirtyProcessingFor(pojo);
- }});
+ }}.run();
}
@Override
@@ -118,19 +118,19 @@ public class IsisLifecycleListener2
//
// 1<->m bidirectional, persistence-by-reachability
- withLogging(new RunnableNoop(event));
+ new RunnableNoop(event).run();
}
@Override
public void preDelete(InstanceLifecycleEvent event) {
- withLogging(new RunnableAbstract(event){
+ new RunnableAbstract(event){
@Override
protected void doRun() {
final Persistable pojo = Utils.persistenceCapableFor(event);
persistenceSession.invokeIsisRemovingCallback(pojo);
}
- });
+ }.run();
}
@Override
@@ -162,12 +162,12 @@ public class IsisLifecycleListener2
@Override
public void preDetach(InstanceLifecycleEvent event) {
- withLogging(new RunnableEnsureRootObject(event));
+ new RunnableEnsureRootObject(event).run();
}
@Override
public void postDetach(InstanceLifecycleEvent event) {
- withLogging(new RunnableEnsureRootObject(event));
+ new RunnableEnsureRootObject(event).run();
}
@@ -175,10 +175,6 @@ public class IsisLifecycleListener2
// withLogging
/////////////////////////////////////////////////////////////////////////
- private void withLogging(Runnable runnable) {
- runnable.run();
- }
-
private abstract class RunnableAbstract implements Runnable {
final InstanceLifecycleEvent event;
public RunnableAbstract(final InstanceLifecycleEvent event) {