You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/18 08:05:37 UTC

[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #6903: [Improvement][Datasource]refactor datasource parsing other parameter

codecov-commenter commented on pull request #6903:
URL: https://github.com/apache/dolphinscheduler/pull/6903#issuecomment-972626379


   # [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/6903?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#6903](https://codecov.io/gh/apache/dolphinscheduler/pull/6903?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0337b37) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/9113817b788b820a19ced3856fc7e2d7b6549832?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9113817) will **decrease** coverage by `8.60%`.
   > The diff coverage is `76.08%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dolphinscheduler/pull/6903/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dolphinscheduler/pull/6903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #6903      +/-   ##
   ============================================
   - Coverage     41.83%   33.23%   -8.61%     
   + Complexity     3618     1614    -2004     
   ============================================
     Files           641      433     -208     
     Lines         25895    14231   -11664     
     Branches       2795     1429    -1366     
   ============================================
   - Hits          10833     4729    -6104     
   + Misses        14081     9058    -5023     
   + Partials        981      444     -537     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/6903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/dolphinscheduler/spi/utils/Constants.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc3BpL3V0aWxzL0NvbnN0YW50cy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...urce/clickhouse/ClickHouseDatasourceProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9kYXRhc291cmNlL2FwaS9kYXRhc291cmNlL2NsaWNraG91c2UvQ2xpY2tIb3VzZURhdGFzb3VyY2VQcm9jZXNzb3IuamF2YQ==) | `60.52% <50.00%> (+8.52%)` | :arrow_up: |
   | [...rce/api/datasource/db2/Db2DatasourceProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9kYXRhc291cmNlL2FwaS9kYXRhc291cmNlL2RiMi9EYjJEYXRhc291cmNlUHJvY2Vzc29yLmphdmE=) | `56.75% <50.00%> (+5.73%)` | :arrow_up: |
   | [...e/api/datasource/hive/HiveDatasourceProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9kYXRhc291cmNlL2FwaS9kYXRhc291cmNlL2hpdmUvSGl2ZURhdGFzb3VyY2VQcm9jZXNzb3IuamF2YQ==) | `38.88% <50.00%> (+1.98%)` | :arrow_up: |
   | [...i/datasource/oracle/OracleDatasourceProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9kYXRhc291cmNlL2FwaS9kYXRhc291cmNlL29yYWNsZS9PcmFjbGVEYXRhc291cmNlUHJvY2Vzc29yLmphdmE=) | `51.11% <50.00%> (+5.49%)` | :arrow_up: |
   | [...urce/postgresql/PostgreSqlDatasourceProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9kYXRhc291cmNlL2FwaS9kYXRhc291cmNlL3Bvc3RncmVzcWwvUG9zdGdyZVNxbERhdGFzb3VyY2VQcm9jZXNzb3IuamF2YQ==) | `55.26% <50.00%> (+7.26%)` | :arrow_up: |
   | [...i/datasource/presto/PrestoDatasourceProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9kYXRhc291cmNlL2FwaS9kYXRhc291cmNlL3ByZXN0by9QcmVzdG9EYXRhc291cmNlUHJvY2Vzc29yLmphdmE=) | `56.75% <50.00%> (+7.77%)` | :arrow_up: |
   | [...api/datasource/spark/SparkDatasourceProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9kYXRhc291cmNlL2FwaS9kYXRhc291cmNlL3NwYXJrL1NwYXJrRGF0YXNvdXJjZVByb2Nlc3Nvci5qYXZh) | `44.64% <50.00%> (+3.46%)` | :arrow_up: |
   | [...source/sqlserver/SqlServerDatasourceProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9kYXRhc291cmNlL2FwaS9kYXRhc291cmNlL3NxbHNlcnZlci9TcWxTZXJ2ZXJEYXRhc291cmNlUHJvY2Vzc29yLmphdmE=) | `54.05% <50.00%> (+6.13%)` | :arrow_up: |
   | [...ce/api/datasource/AbstractDatasourceProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9kYXRhc291cmNlL2FwaS9kYXRhc291cmNlL0Fic3RyYWN0RGF0YXNvdXJjZVByb2Nlc3Nvci5qYXZh) | `77.08% <88.00%> (+11.86%)` | :arrow_up: |
   | ... and [252 more](https://codecov.io/gh/apache/dolphinscheduler/pull/6903/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/6903?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/6903?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9113817...0337b37](https://codecov.io/gh/apache/dolphinscheduler/pull/6903?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org