You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2023/11/21 20:38:17 UTC
[I] Modify upgrader to error if 'tserver.last.location.mode' is set [accumulo]
dlmarion opened a new issue, #3972:
URL: https://github.com/apache/accumulo/issues/3972
#3926 removed this property. Modify the upgrader to fail if the property is set. We may want to consider just generically failing the upgrade if any property is set that no longer exists?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Modify upgrader to error if 'tserver.last.location.mode' is set [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #3972:
URL: https://github.com/apache/accumulo/issues/3972#issuecomment-1823275161
Found the following in the code
> I'm not sure. I thought we already had something like that.
https://github.com/apache/accumulo/blob/df362efeee3113d3e3c23ff6f6778f394a588363/core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java#L204
https://github.com/apache/accumulo/blob/df362efeee3113d3e3c23ff6f6778f394a588363/server/base/src/main/java/org/apache/accumulo/server/conf/ServerConfigurationFactory.java#L118
So maybe warns are logged when tables or site configs have props that do not validate. Not related to this PR, but wondering if the system config in ZK should also be validated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Modify upgrader to error if 'tserver.last.location.mode' is set [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on issue #3972:
URL: https://github.com/apache/accumulo/issues/3972#issuecomment-1821712637
> Is it really worth failing? Maybe this should just be a warning that an unrecognized property exists, and that perhaps it was one that was removed?
Do you think this should be a warning for all unknown properties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Modify upgrader to error if 'tserver.last.location.mode' is set [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #3972:
URL: https://github.com/apache/accumulo/issues/3972#issuecomment-1823326078
> Not related to this PR, but wondering if the system config in ZK should also be validated.
opened #3978 to address this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Modify upgrader to error if 'tserver.last.location.mode' is set [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion closed issue #3972: Modify upgrader to error if 'tserver.last.location.mode' is set
URL: https://github.com/apache/accumulo/issues/3972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Modify upgrader to error if 'tserver.last.location.mode' is set [accumulo]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on issue #3972:
URL: https://github.com/apache/accumulo/issues/3972#issuecomment-1821707842
Is it really worth failing? Maybe this should just be a warning that an unrecognized property exists, and that perhaps it was one that was removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Modify upgrader to error if 'tserver.last.location.mode' is set [accumulo]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on issue #3972:
URL: https://github.com/apache/accumulo/issues/3972#issuecomment-1821785705
> > Is it really worth failing? Maybe this should just be a warning that an unrecognized property exists, and that perhaps it was one that was removed?
>
> Do you think this should be a warning for all unknown properties?
I'm not sure. I thought we already had something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Modify upgrader to error if 'tserver.last.location.mode' is set [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on issue #3972:
URL: https://github.com/apache/accumulo/issues/3972#issuecomment-1959911698
Closed by #4289 which validates the configuration during the upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org