Re: [jira] Updated: (FOR-811) shine and polish the pelt theme so that it closely resembles the pelt skin

[Thorsten Scherler <th...@apache.org>]

El mié, 15-02-2006 a las 09:32 +0100, Cyriaque Dupoirieux escribió:
> Gav.... a écrit :
> > 
...
> > | >
> > | > 3 Attatchments go a way towards addressing this issue. There are still 
> > some minor adjustments to make, however what has been done needs checking 
> > first. The CSS file pelt.basic.css has been done away with and any 
> > applicable CSS from it transferred into pelt.screen.css. Some changes were 
> > required also to pelt.fv and siteinfo-credits.fv.
> > | >
> > | Thank you for you work Gavin,
> > |
> > | Don't understand why the basic has been removed ?
> > | It must contain the css applicable independently of the device (print,
> > | screen...) Doesn't it ?
> >
> > Not as far as I know it doesn't. Default device is screen anyway, the 
> > print.css
> > is still there, to strip away anything that does not need printing - that 
> > needs
> > looking at too anyway. The leather-dev.css is still there, and anything else
> > can be used if need be using inheritence to override any css in screen.css
> > such as if a pda/mobile view was needed. There was duplicate and conflicting
> > code on basic and screen that I didnt see as being inheritence. As part of
> > the pelt theme conversion and cleanup it was discussed last Forrest Friday
> > and consensus was that we merge some css together.
> >
> > If you find a compelling reason to keep basic.css let us know, it is gone
> > from my system only atm. I could not see how basic.css could be used
> > on its own.
> >   
> It's Ok for me, you can remove the file if it is not useful.
> Cyriaque,

Actually Gav, if you want to write the css from scratch, be our
guest ;-) IMO that makes heaps sense.

Thanks for your your contribution (as soon as I am back from the
conference I will apply your patch - if nobody beats me to it).

Keep up the good work.

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)

Re: [jira] Updated: (FOR-811) shine and polish the pelt theme sothat it closely resembles the pelt skin

["Gav...." <br...@brightontown.com.au>]

----- Original Message ----- 
From: "Thorsten Scherler" <th...@apache.org>
To: <de...@forrest.apache.org>
Sent: Wednesday, February 15, 2006 5:12 PM
Subject: Re: [jira] Updated: (FOR-811) shine and polish the pelt theme 
sothat it closely resembles the pelt skin


| El mié, 15-02-2006 a las 09:32 +0100, Cyriaque Dupoirieux escribió:
| > Gav.... a écrit :
| > >
| ...
| > > | >
| > > | > 3 Attatchments go a way towards addressing this issue. There are 
still
| > > some minor adjustments to make, however what has been done needs 
checking
| > > first. The CSS file pelt.basic.css has been done away with and any
| > > applicable CSS from it transferred into pelt.screen.css. Some changes 
were
| > > required also to pelt.fv and siteinfo-credits.fv.
| > > | >
| > > | Thank you for you work Gavin,
| > > |
| > > | Don't understand why the basic has been removed ?
| > > | It must contain the css applicable independently of the device 
(print,
| > > | screen...) Doesn't it ?
| > >
| > > Not as far as I know it doesn't. Default device is screen anyway, the
| > > print.css
| > > is still there, to strip away anything that does not need printing - 
that
| > > needs
| > > looking at too anyway. The leather-dev.css is still there, and 
anything else
| > > can be used if need be using inheritence to override any css in 
screen.css
| > > such as if a pda/mobile view was needed. There was duplicate and 
conflicting
| > > code on basic and screen that I didnt see as being inheritence. As 
part of
| > > the pelt theme conversion and cleanup it was discussed last Forrest 
Friday
| > > and consensus was that we merge some css together.
| > >
| > > If you find a compelling reason to keep basic.css let us know, it is 
gone
| > > from my system only atm. I could not see how basic.css could be used
| > > on its own.
| > >
| > It's Ok for me, you can remove the file if it is not useful.
| > Cyriaque,
|
| Actually Gav, if you want to write the css from scratch, be our
| guest ;-) IMO that makes heaps sense.

I will keep looking at it, not sure a complete rewrite is neccessary
but will have a more detailed look and see.

|
| Thanks for your your contribution (as soon as I am back from the
| conference I will apply your patch - if nobody beats me to it).
|
| Keep up the good work.

No problem, at this stage I will continue on making local changes, but
will not send any more patches until these have been applied and
tested to be ok.

Good luck at the conf, hows it going ?

Gav...

|
| salu2
| -- 
| thorsten
|
| "Together we stand, divided we fall!"
| Hey you (Pink Floyd)
|
|
|
| -- 
| No virus found in this incoming message.
| Checked by AVG Free Edition.
| Version: 7.1.375 / Virus Database: 267.15.8/260 - Release Date: 14/02/2006
|
| 



-- 
No virus found in this outgoing message.
Checked by AVG Free Edition.
Version: 7.1.375 / Virus Database: 267.15.9/261 - Release Date: 15/02/2006