You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by jm...@apache.org on 2017/03/19 05:59:50 UTC
[2/5] git commit: [flex-asjs] [refs/heads/develop] - used simplier
undefined check as it is known property exists
used simplier undefined check as it is known property exists
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/30849715
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/30849715
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/30849715
Branch: refs/heads/develop
Commit: 30849715a562eaa36f51f3fbc1492a447342debb
Parents: 8daf726
Author: Justin Mclean <jm...@apache.org>
Authored: Sun Mar 19 15:17:22 2017 +1100
Committer: Justin Mclean <jm...@apache.org>
Committed: Sun Mar 19 15:17:22 2017 +1100
----------------------------------------------------------------------
.../Network/src/main/flex/org/apache/flex/net/HTTPService.as | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/30849715/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
index 13c5a9c..46a7b16 100644
--- a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
+++ b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
@@ -269,7 +269,7 @@ package org.apache.flex.net
var part2:String;
var element:XMLHttpRequest = this.element as XMLHttpRequest;
- if (typeof _responseHeaders === 'undefined') {
+ if (_responseHeaders === undefined) {
allHeaders = element.getAllResponseHeaders();
_responseHeaders = allHeaders.split('\n');
n = _responseHeaders.length;
Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - used
simplier undefined check as it is known property exists
Posted by Piotr Zarzycki <pi...@gmail.com>.
Hi Justin,
What happened if it will be null?
Piotr
On Sun, Mar 19, 2017, 06:59 <jm...@apache.org> wrote:
> used simplier undefined check as it is known property exists
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/30849715
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/30849715
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/30849715
>
> Branch: refs/heads/develop
> Commit: 30849715a562eaa36f51f3fbc1492a447342debb
> Parents: 8daf726
> Author: Justin Mclean <jm...@apache.org>
> Authored: Sun Mar 19 15:17:22 2017 +1100
> Committer: Justin Mclean <jm...@apache.org>
> Committed: Sun Mar 19 15:17:22 2017 +1100
>
> ----------------------------------------------------------------------
> .../Network/src/main/flex/org/apache/flex/net/HTTPService.as | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/30849715/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> ----------------------------------------------------------------------
> diff --git
> a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> index 13c5a9c..46a7b16 100644
> ---
> a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> +++
> b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> @@ -269,7 +269,7 @@ package org.apache.flex.net
> var part2:String;
> var element:XMLHttpRequest = this.element as
> XMLHttpRequest;
>
> - if (typeof _responseHeaders === 'undefined') {
> + if (_responseHeaders === undefined) {
> allHeaders = element.getAllResponseHeaders();
> _responseHeaders = allHeaders.split('\n');
> n = _responseHeaders.length;
>
>
Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - used
simplier undefined check as it is known property exists
Posted by Piotr Zarzycki <pi...@gmail.com>.
Hi Justin,
What happened if it will be null?
Piotr
On Sun, Mar 19, 2017, 06:59 <jm...@apache.org> wrote:
> used simplier undefined check as it is known property exists
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/30849715
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/30849715
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/30849715
>
> Branch: refs/heads/develop
> Commit: 30849715a562eaa36f51f3fbc1492a447342debb
> Parents: 8daf726
> Author: Justin Mclean <jm...@apache.org>
> Authored: Sun Mar 19 15:17:22 2017 +1100
> Committer: Justin Mclean <jm...@apache.org>
> Committed: Sun Mar 19 15:17:22 2017 +1100
>
> ----------------------------------------------------------------------
> .../Network/src/main/flex/org/apache/flex/net/HTTPService.as | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/30849715/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> ----------------------------------------------------------------------
> diff --git
> a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> index 13c5a9c..46a7b16 100644
> ---
> a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> +++
> b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> @@ -269,7 +269,7 @@ package org.apache.flex.net
> var part2:String;
> var element:XMLHttpRequest = this.element as
> XMLHttpRequest;
>
> - if (typeof _responseHeaders === 'undefined') {
> + if (_responseHeaders === undefined) {
> allHeaders = element.getAllResponseHeaders();
> _responseHeaders = allHeaders.split('\n');
> n = _responseHeaders.length;
>
>