You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/02 21:52:54 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #15163: Fix exception caused by missing keys in the ES Record

kaxil commented on a change in pull request #15163:
URL: https://github.com/apache/airflow/pull/15163#discussion_r606438807



##########
File path: airflow/providers/elasticsearch/log/es_task_handler.py
##########
@@ -207,7 +207,7 @@ def _format_msg(self, log_line):
         if self.json_format:
             try:
                 # pylint: disable=protected-access
-                return self.formatter._style.format(_ESJsonLogFmt(**log_line.to_dict()))
+                return self.formatter._style.format(_ESJsonLogFmt(self.json_fields, **log_line.to_dict()))

Review comment:
       @millin Thanks for the PR, can you please also add a test case or update an existing test in https://github.com/apache/airflow/blob/master/tests/providers/elasticsearch/log/test_es_task_handler.py




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org