You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "HennesyChihiro (via GitHub)" <gi...@apache.org> on 2026/01/30 12:33:15 UTC
[PR] Spark: Fix date rebase issues in ORC writing and metrics collection [iceberg]
HennesyChihiro opened a new pull request, #15188:
URL: https://github.com/apache/iceberg/pull/15188
Problem
When writing historical dates (pre-1582) to ORC files in Spark, there is a discrepancy between the written data and the collected metrics due to Julian-Gregorian calendar rebase issues. This causes consistency checks to fail.
Modification
Updated GenericOrcWriters.java to ensure dates are correctly handled during the write process.
Adjusted OrcMetrics.java to align metrics collection with the corrected writing logic, ensuring the min/max values reflect the actual data on disk.
Verification Results
Ran ./gradlew :iceberg-orc:test and confirmed that the specific test cases for historical dates now pass without metric mismatches.
Fixes #14214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Fix date rebase issues in ORC writing and metrics collection [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15188:
URL: https://github.com/apache/iceberg/pull/15188#issuecomment-3981394947
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Fix date rebase issues in ORC writing and metrics collection [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15188:
URL: https://github.com/apache/iceberg/pull/15188#issuecomment-4020366527
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Fix date rebase issues in ORC writing and metrics collection [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #15188: Spark: Fix date rebase issues in ORC writing and metrics collection
URL: https://github.com/apache/iceberg/pull/15188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org