You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/27 09:01:41 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4145: Don't hardcode port in FlightSQL tests

tustvold commented on code in PR #4145:
URL: https://github.com/apache/arrow-rs/pull/4145#discussion_r1178841035


##########
arrow-flight/examples/flight_sql_server.rs:
##########
@@ -609,11 +623,8 @@ mod tests {
 
     #[tokio::test]
     async fn test_select_https() {
-        tokio::spawn(async {
-            create_https_server().await.unwrap();
-        });
-
-        sleep(Duration::from_millis(2000)).await;

Review Comment:
   As an added bonus, this sleep is no longer necessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org