You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/19 06:17:31 UTC
[GitHub] [dolphinscheduler] exmy opened a new issue, #9576: [Improvemenr][server] varPool support "#{setValue(key=value)}"
exmy opened a new issue, #9576:
URL: https://github.com/apache/dolphinscheduler/issues/9576
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Currently var pool only support '${setValue(key=value)}', which has a limitation that value cannot reference other variables.
For example,
```shell
d=$(date "+%F %H-%M-%S")
echo '${setValue(day=${d})}'
```
Since single quotes won't interpolate anything, we cannot use ${d} in ${setValue}, so I think we can support #{setValue(key=value)} to avoid this.
like follow:
```shell
d=$(date "+%F %H-%M-%S")
echo "#{setValue(day=${d})}"
```
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #9576: [Improvement][server] varPool support "#{setValue(key=value)}"
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #9576:
URL: https://github.com/apache/dolphinscheduler/issues/9576#issuecomment-1104817513
I know @jieguangzhou also thinks we should have this feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] jieguangzhou commented on issue #9576: [Improvement][server] varPool support "#{setValue(key=value)}"
Posted by GitBox <gi...@apache.org>.
jieguangzhou commented on issue #9576:
URL: https://github.com/apache/dolphinscheduler/issues/9576#issuecomment-1106068441
good job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on issue #9576: [Improvement][server] varPool support "#{setValue(key=value)}"
Posted by GitBox <gi...@apache.org>.
songjianet commented on issue #9576:
URL: https://github.com/apache/dolphinscheduler/issues/9576#issuecomment-1102143819
Will there be any changes to the front-end part here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] exmy commented on issue #9576: [Improvement][server] varPool support "#{setValue(key=value)}"
Posted by GitBox <gi...@apache.org>.
exmy commented on issue #9576:
URL: https://github.com/apache/dolphinscheduler/issues/9576#issuecomment-1106150673
thx, I will supplement this part of the document soon later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on issue #9576: [Improvement][server] varPool support "#{setValue(key=value)}"
Posted by GitBox <gi...@apache.org>.
songjianet commented on issue #9576:
URL: https://github.com/apache/dolphinscheduler/issues/9576#issuecomment-1102166242
> The front-end part does not need any change.
Thanks. I got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #9576: [Improvemenr][server] varPool support "#{setValue(key=value)}"
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #9576:
URL: https://github.com/apache/dolphinscheduler/issues/9576#issuecomment-1102134975
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://join.slack.com/t/asf-dolphinscheduler/shared_invite/zt-omtdhuio-_JISsxYhiVsltmC5h38yfw) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie closed issue #9576: [Improvement][server] varPool support "#{setValue(key=value)}"
Posted by GitBox <gi...@apache.org>.
zhongjiajie closed issue #9576: [Improvement][server] varPool support "#{setValue(key=value)}"
URL: https://github.com/apache/dolphinscheduler/issues/9576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #9576: [Improvement][server] varPool support "#{setValue(key=value)}"
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #9576:
URL: https://github.com/apache/dolphinscheduler/issues/9576#issuecomment-1104816190
Looking great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] exmy commented on issue #9576: [Improvement][server] varPool support "#{setValue(key=value)}"
Posted by GitBox <gi...@apache.org>.
exmy commented on issue #9576:
URL: https://github.com/apache/dolphinscheduler/issues/9576#issuecomment-1102149710
The front-end part does not need any change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #9576: [Improvement][server] varPool support "#{setValue(key=value)}"
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #9576:
URL: https://github.com/apache/dolphinscheduler/issues/9576#issuecomment-1106167208
> thx, I will supplement this part of the document soon later.
Oh, I even forget we should add the doc, you could change doc in https://github.com/apache/dolphinscheduler/tree/dev/docs/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org