[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #677: [IOTDB-340] Remove unnecessary getting data types from MManager

[GitBox <gi...@apache.org>]

jt2594838 commented on a change in pull request #677: [IOTDB-340] Remove unnecessary getting data types from MManager 
URL: https://github.com/apache/incubator-iotdb/pull/677#discussion_r361560033
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/PhysicalGenerator.java
 ##########
 @@ -350,6 +352,31 @@ private PhysicalPlan transformQuery(QueryOperator queryOperator)
     return queryPlan;
   }
 
+  private void deduplicate(QueryOperator queryOperator, QueryPlan queryPlan)
+      throws QueryProcessException {
+    if (queryPlan instanceof AggregationPlan || queryPlan instanceof GroupByPlan) {
+      deduplicateAggregation(queryPlan);
+    } else {
+      deduplicate(queryPlan);
+    }
+    if (queryPlan.getDeduplicatedPaths() == null) {
+      queryPlan.setDeduplicatedPaths(queryPlan.getPaths());
+    }
+    if (queryPlan.getDeduplicatedDataTypes() == null) {
 
 Review comment:
   DeduplicatedPaths and DeduplicatedDataTypes are set in either branch of the above "if-else", I doubt the reachability of the two branches.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services