You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/05 03:08:51 UTC

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #15282: [improve][broker] Add `individualDeletedMessagesSize` to log when cusor close.

gaoran10 commented on code in PR #15282:
URL: https://github.com/apache/pulsar/pull/15282#discussion_r865527097


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2333,6 +2338,9 @@ public void closeFailed(ManagedLedgerException exception, Object ctx) {
      */
     void persistPositionWhenClosing(PositionImpl position, Map<String, Long> properties,
             final AsyncCallbacks.CloseCallback callback, final Object ctx) {
+        log.info("Persistence before cursor close is in progress. position={} "

Review Comment:
   I'm not sure that we need to add this log, it seems that there are logs when this operation was completed successfully or not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org