You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2026/05/17 12:49:13 UTC
(maven-dependency-plugin) 01/01: Remove unthrown exceptions
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch ex
in repository https://gitbox.apache.org/repos/asf/maven-dependency-plugin.git
commit 1936d50d5809a40463cc2b12ba8f31df3981bfc7
Author: Elliotte Rusty Harold <el...@ibiblio.org>
AuthorDate: Sun May 17 08:48:58 2026 -0400
Remove unthrown exceptions
---
.../apache/maven/plugins/dependency/AddDependencyMojo.java | 2 +-
.../apache/maven/plugins/dependency/RemoveDependencyMojo.java | 3 +--
.../org/apache/maven/plugins/dependency/tree/TreeMojo.java | 3 +--
.../dependency/utils/markers/SourcesFileMarkerHandler.java | 11 +++--------
.../maven/plugins/dependency/AddDependencyMojoTest.java | 2 +-
.../maven/plugins/dependency/RemoveDependencyMojoTest.java | 2 +-
.../org/apache/maven/plugins/dependency/TestCollectMojo.java | 4 ++--
.../plugins/dependency/exclusion/ExclusionCheckerTest.java | 2 +-
.../dependency/fromConfiguration/TestArtifactItem.java | 2 +-
.../plugins/dependency/fromConfiguration/TestUnpackMojo.java | 2 +-
.../plugins/dependency/utils/filters/TestDestFileFilter.java | 2 +-
11 files changed, 14 insertions(+), 21 deletions(-)
diff --git a/src/main/java/org/apache/maven/plugins/dependency/AddDependencyMojo.java b/src/main/java/org/apache/maven/plugins/dependency/AddDependencyMojo.java
index 0aec3fcb..396445fc 100644
--- a/src/main/java/org/apache/maven/plugins/dependency/AddDependencyMojo.java
+++ b/src/main/java/org/apache/maven/plugins/dependency/AddDependencyMojo.java
@@ -631,7 +631,7 @@ public class AddDependencyMojo extends AbstractDependencyMojo {
/**
* Detects the project's dependency management conventions by analyzing existing dependencies.
*/
- private Conventions detectConventions(MavenProject project) throws MojoExecutionException {
+ private Conventions detectConventions(MavenProject project) {
Conventions conv = new Conventions();
File pomFile = project.getFile();
diff --git a/src/main/java/org/apache/maven/plugins/dependency/RemoveDependencyMojo.java b/src/main/java/org/apache/maven/plugins/dependency/RemoveDependencyMojo.java
index c6171793..d525b8bc 100644
--- a/src/main/java/org/apache/maven/plugins/dependency/RemoveDependencyMojo.java
+++ b/src/main/java/org/apache/maven/plugins/dependency/RemoveDependencyMojo.java
@@ -271,8 +271,7 @@ public class RemoveDependencyMojo extends AbstractDependencyMojo {
return coords;
}
- private void checkChildModuleDependencies(MavenProject parentProject, String depGroupId, String depArtifactId)
- throws MojoExecutionException {
+ private void checkChildModuleDependencies(MavenProject parentProject, String depGroupId, String depArtifactId) {
if (parentProject.getBasedir() == null) {
getLog().debug("Parent project basedir is null, skipping child module dependency check");
return;
diff --git a/src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java b/src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java
index a2e7d8e8..f6c2df38 100644
--- a/src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java
+++ b/src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java
@@ -33,7 +33,6 @@ import org.apache.maven.artifact.resolver.filter.ScopeArtifactFilter;
import org.apache.maven.execution.MavenSession;
import org.apache.maven.plugin.AbstractMojo;
import org.apache.maven.plugin.MojoExecutionException;
-import org.apache.maven.plugin.MojoFailureException;
import org.apache.maven.plugins.annotations.Mojo;
import org.apache.maven.plugins.annotations.Parameter;
import org.apache.maven.plugins.annotations.ResolutionScope;
@@ -220,7 +219,7 @@ public class TreeMojo extends AbstractMojo {
* @see org.apache.maven.plugin.Mojo#execute()
*/
@Override
- public void execute() throws MojoExecutionException, MojoFailureException {
+ public void execute() throws MojoExecutionException {
if (isSkip()) {
getLog().info("Skipping plugin execution");
return;
diff --git a/src/main/java/org/apache/maven/plugins/dependency/utils/markers/SourcesFileMarkerHandler.java b/src/main/java/org/apache/maven/plugins/dependency/utils/markers/SourcesFileMarkerHandler.java
index 7cd9cef9..e5555100 100644
--- a/src/main/java/org/apache/maven/plugins/dependency/utils/markers/SourcesFileMarkerHandler.java
+++ b/src/main/java/org/apache/maven/plugins/dependency/utils/markers/SourcesFileMarkerHandler.java
@@ -80,12 +80,9 @@ public class SourcesFileMarkerHandler extends DefaultFileMarkerHandler {
*
* @return <code>true</code> if and only if the file or directory denoted by this abstract pathname exists;
* <code>false</code> otherwise
- * @throws MojoExecutionException if a security manager exists and its <code>{@link
- * java.lang.SecurityManager#checkRead(java.lang.String)}</code> method denies read access to the file or
- * directory
*/
@Override
- public boolean isMarkerSet() throws MojoExecutionException {
+ public boolean isMarkerSet() {
File marker = getMarkerFile();
File marker2 = getMarkerFile(!this.resolved);
@@ -94,7 +91,7 @@ public class SourcesFileMarkerHandler extends DefaultFileMarkerHandler {
}
@Override
- public boolean isMarkerOlder(Artifact theArtifact) throws MojoExecutionException {
+ public boolean isMarkerOlder(Artifact theArtifact) {
File marker = getMarkerFile();
if (marker.exists()) {
return theArtifact.getFile().lastModified() > marker.lastModified();
@@ -142,11 +139,9 @@ public class SourcesFileMarkerHandler extends DefaultFileMarkerHandler {
*
* @return <code>true</code> if and only if the file or directory is successfully deleted; <code>false</code>
* otherwise
- * @throws SecurityException if a security manager exists and its <code>{@link
- * java.lang.SecurityManager#checkDelete}</code> method denies delete access to the file
*/
@Override
- public boolean clearMarker() throws MojoExecutionException {
+ public boolean clearMarker() {
File marker = getMarkerFile();
File marker2 = getMarkerFile(!this.resolved);
boolean markResult = marker.delete();
diff --git a/src/test/java/org/apache/maven/plugins/dependency/AddDependencyMojoTest.java b/src/test/java/org/apache/maven/plugins/dependency/AddDependencyMojoTest.java
index e66f38bf..ad7a7ce1 100644
--- a/src/test/java/org/apache/maven/plugins/dependency/AddDependencyMojoTest.java
+++ b/src/test/java/org/apache/maven/plugins/dependency/AddDependencyMojoTest.java
@@ -60,7 +60,7 @@ class AddDependencyMojoTest {
private AddDependencyMojo mojo;
@BeforeEach
- void setUp() throws Exception {
+ void setUp() {
session = mock(MavenSession.class);
buildContext = mock(BuildContext.class);
project = mock(MavenProject.class);
diff --git a/src/test/java/org/apache/maven/plugins/dependency/RemoveDependencyMojoTest.java b/src/test/java/org/apache/maven/plugins/dependency/RemoveDependencyMojoTest.java
index 44949363..000d49a1 100644
--- a/src/test/java/org/apache/maven/plugins/dependency/RemoveDependencyMojoTest.java
+++ b/src/test/java/org/apache/maven/plugins/dependency/RemoveDependencyMojoTest.java
@@ -58,7 +58,7 @@ class RemoveDependencyMojoTest {
private RemoveDependencyMojo mojo;
@BeforeEach
- void setUp() throws Exception {
+ void setUp() {
session = mock(MavenSession.class);
buildContext = mock(BuildContext.class);
project = mock(MavenProject.class);
diff --git a/src/test/java/org/apache/maven/plugins/dependency/TestCollectMojo.java b/src/test/java/org/apache/maven/plugins/dependency/TestCollectMojo.java
index 62098d61..33e45d49 100644
--- a/src/test/java/org/apache/maven/plugins/dependency/TestCollectMojo.java
+++ b/src/test/java/org/apache/maven/plugins/dependency/TestCollectMojo.java
@@ -43,7 +43,7 @@ class TestCollectMojo {
private DependencyArtifactStubFactory stubFactory;
@BeforeEach
- void setUp() throws Exception {
+ void setUp() {
stubFactory = new DependencyArtifactStubFactory(null, false);
}
@@ -101,7 +101,7 @@ class TestCollectMojo {
@Test
@InjectMojo(goal = "collect")
- void testSilent(CollectDependenciesMojo mojo) throws Exception {
+ void testSilent(CollectDependenciesMojo mojo) {
assertFalse(mojo.getLog() instanceof DependencySilentLog);
mojo.setSilent(true);
diff --git a/src/test/java/org/apache/maven/plugins/dependency/exclusion/ExclusionCheckerTest.java b/src/test/java/org/apache/maven/plugins/dependency/exclusion/ExclusionCheckerTest.java
index 2663595d..a0e03d84 100644
--- a/src/test/java/org/apache/maven/plugins/dependency/exclusion/ExclusionCheckerTest.java
+++ b/src/test/java/org/apache/maven/plugins/dependency/exclusion/ExclusionCheckerTest.java
@@ -34,7 +34,7 @@ class ExclusionCheckerTest {
private ExclusionChecker checker;
@BeforeEach
- void setUp() throws Exception {
+ void setUp() {
checker = new ExclusionChecker();
}
diff --git a/src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestArtifactItem.java b/src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestArtifactItem.java
index f29043cd..ed2cc3cd 100644
--- a/src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestArtifactItem.java
+++ b/src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestArtifactItem.java
@@ -29,7 +29,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
class TestArtifactItem {
@Test
- void testArtifactItemConstructor() throws IOException {
+ void testArtifactItemConstructor() {
Artifact artifact = new DefaultArtifact("g", "a", "1.0", Artifact.SCOPE_COMPILE, "jar", "one", null);
ArtifactItem item = new ArtifactItem(artifact);
diff --git a/src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestUnpackMojo.java b/src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestUnpackMojo.java
index 06a53c12..ac466936 100644
--- a/src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestUnpackMojo.java
+++ b/src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestUnpackMojo.java
@@ -72,7 +72,7 @@ class TestUnpackMojo {
private ArchiverManager archiverManager;
@BeforeEach
- void setUp() throws Exception {
+ void setUp() {
stubFactory = new DependencyArtifactStubFactory(tempDir, true, false);
stubFactory.setUnpackableFile(archiverManager);
stubFactory.setSrcFile(MojoExtension.getTestFile("test.txt"));
diff --git a/src/test/java/org/apache/maven/plugins/dependency/utils/filters/TestDestFileFilter.java b/src/test/java/org/apache/maven/plugins/dependency/utils/filters/TestDestFileFilter.java
index e721bbdc..8891184d 100644
--- a/src/test/java/org/apache/maven/plugins/dependency/utils/filters/TestDestFileFilter.java
+++ b/src/test/java/org/apache/maven/plugins/dependency/utils/filters/TestDestFileFilter.java
@@ -44,7 +44,7 @@ class TestDestFileFilter {
private DependencyArtifactStubFactory fact;
@BeforeEach
- void setUp() throws Exception {
+ void setUp() {
this.fact = new DependencyArtifactStubFactory(outputFolder, false);
}