You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by vi...@apache.org on 2006/07/14 13:25:34 UTC
svn commit: r421871 -
/james/server/trunk/src/java/org/apache/james/smtpserver/RcptCmdHandler.java
Author: vincenzo
Date: Fri Jul 14 04:25:34 2006
New Revision: 421871
URL: http://svn.apache.org/viewvc?rev=421871&view=rev
Log:
A fastfail DNSBRL blacklisted message is rejected even if the sender user is successfully SMTP AUTHenticated (see JAMES-566).
The correction is to a misleading long boolean expression, that already gave us a problem in the past.
Modified:
james/server/trunk/src/java/org/apache/james/smtpserver/RcptCmdHandler.java
Modified: james/server/trunk/src/java/org/apache/james/smtpserver/RcptCmdHandler.java
URL: http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/smtpserver/RcptCmdHandler.java?rev=421871&r1=421870&r2=421871&view=diff
==============================================================================
--- james/server/trunk/src/java/org/apache/james/smtpserver/RcptCmdHandler.java (original)
+++ james/server/trunk/src/java/org/apache/james/smtpserver/RcptCmdHandler.java Fri Jul 14 04:25:34 2006
@@ -188,7 +188,7 @@
}
if (session.isBlockListed() && // was found in the RBL
- (!session.isRelayingAllowed() || (session.isAuthRequired() && session.getUser() == null)) && // Not an authorized IP or SMTP AUTH is enabled and not authenticated
+ !(session.isRelayingAllowed() || (session.isAuthRequired() && session.getUser() != null)) && // Not (either an authorized IP or (SMTP AUTH is enabled and not authenticated))
!(recipientAddress.getUser().equalsIgnoreCase("postmaster") || recipientAddress.getUser().equalsIgnoreCase("abuse"))) {
// trying to send e-mail to other than postmaster or abuse
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org