[GitHub] [tvm] MasterJH5574 commented on a diff in pull request #11050: [TIR] Utility function to decide loop mapping for auto tensorization

[GitBox <gi...@apache.org>]

MasterJH5574 commented on code in PR #11050:
URL: https://github.com/apache/tvm/pull/11050#discussion_r852547688


##########
python/tvm/tir/schedule/analysis.py:
##########
@@ -56,3 +60,28 @@ def suggest_index_map(
         loops,
         predicate,
     )
+
+
+@tvm._ffi.register_object("tir.schedule.TensorizeInfo")
+class TensorizeInfo(Object):
+    """Necessary information used for tensorization."""
+
+
+def get_tensorize_loop_mapping(sch: Schedule, block: BlockRV, desc_func: PrimFunc) -> TensorizeInfo:

Review Comment:
   Should it be as the following? Since I note that the return type annotation is inconsistent with the document.
   ```suggestion
   def get_tensorize_loop_mapping(sch: Schedule, block: BlockRV, desc_func: PrimFunc) -> Optional[TensorizeInfo]:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org