[jira] [Commented] (BUILDR-702) Merging zip files does not retain file permissions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BUILDR-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113835#comment-14113835 ] 

ASF GitHub Bot commented on BUILDR-702:
---------------------------------------

GitHub user pepijnve opened a pull request:

    https://github.com/apache/buildr/pull/15

    BUILDR-702: Retain unix permissions when merging zip files

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pepijnve/buildr buildr_702

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/buildr/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit 5b7933a57bbc53ba80c90538c8681fabe7b82568
Author: Pepijn Van Eeckhoudt <pe...@vaneeckhoudt.net>
Date:   2014-08-28T15:12:59Z

    BUILDR-702: Retain unix permissions when merging zip files

----


> Merging zip files does not retain file permissions
> --------------------------------------------------
>
>                 Key: BUILDR-702
>                 URL: https://issues.apache.org/jira/browse/BUILDR-702
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 1.4.19
>            Reporter: Pepijn Van Eeckhoudt
>
> Given a project containing a file `script.sh` with certain unix permissions set on it; the following project will not retain those permissions in merged-0.1.zip
> {code}
> define 'foo', :version => 0.1 do
>   base = package(:zip, :id => 'base').tap do |pkg|
>     pkg.include _('script.sh')
>   end
>   package(:zip, :id => 'merged').tap do |pkg|
>     pkg.merge base
>   end
> end
> {code}
> This is caused by the way ZipExpander and ZipTask work together. Zip entries are passed through as Procs and don't get the opportunity to set permissions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)