You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/19 10:21:37 UTC
[GitHub] [airflow] kaxil opened a new pull request #7211: [AIRFLOW-XXXX]
Enforce description should not be empty
kaxil opened a new pull request #7211: [AIRFLOW-XXXX] Enforce description should not be empty
URL: https://github.com/apache/airflow/pull/7211
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7211: [AIRFLOW-6596] Enforce
description should not be empty
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7211: [AIRFLOW-6596] Enforce description should not be empty
URL: https://github.com/apache/airflow/pull/7211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil edited a comment on issue #7211: [AIRFLOW-XXXX]
Enforce description should not be empty
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #7211: [AIRFLOW-XXXX] Enforce description should not be empty
URL: https://github.com/apache/airflow/pull/7211#issuecomment-575989421
Example:
**Fails when no description of the change or PR is specified**:
Mergeable failed with the default PR description where I don't enter any information:
**Passes when the description of the change or PR is specified**:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7211: [AIRFLOW-XXXX] Enforce
description should not be empty
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7211: [AIRFLOW-XXXX] Enforce description should not be empty
URL: https://github.com/apache/airflow/pull/7211#issuecomment-575989421
Example:
Mergeable failed with the default PR description where I don't enter any information:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7211: [AIRFLOW-XXXX] Enforce
description should not be empty
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7211: [AIRFLOW-XXXX] Enforce description should not be empty
URL: https://github.com/apache/airflow/pull/7211#issuecomment-575989794
Should we create jira ticket?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7211: [AIRFLOW-6596] Enforce
description should not be empty
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7211: [AIRFLOW-6596] Enforce description should not be empty
URL: https://github.com/apache/airflow/pull/7211#issuecomment-575989978
> Should we create jira ticket?
Created and added in PR Title and description :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7211: [AIRFLOW-6596] Enforce
description should not be empty
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7211: [AIRFLOW-6596] Enforce description should not be empty
URL: https://github.com/apache/airflow/pull/7211#issuecomment-575994158
Love it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services