You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/21 21:29:15 UTC

[GitHub] [incubator-superset] adam-stasiak opened a new pull request #10984: chore: Cypress explore vis tests

adam-stasiak opened a new pull request #10984:
URL: https://github.com/apache/incubator-superset/pull/10984


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   I moved class oriented selectors to use data-test selectors. Some selectors related to charts is not changed because it requires changes in external superset-ui library.
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Run Cypress Explore test suite
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10984: chore: Cypress explore visualization tests refactor

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #10984:
URL: https://github.com/apache/incubator-superset/pull/10984#issuecomment-700702583


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=h1) Report
   > Merging [#10984](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5d08a426d30e7e3b32e09541937f466889c2319b?el=desc) will **increase** coverage by `0.37%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10984/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10984      +/-   ##
   ==========================================
   + Coverage   61.17%   61.55%   +0.37%     
   ==========================================
     Files         384      817     +433     
     Lines       24287    38688   +14401     
     Branches        0     3650    +3650     
   ==========================================
   + Hits        14858    23813    +8955     
   - Misses       9429    14695    +5266     
   - Partials        0      180     +180     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.18% <60.00%> (?)` | |
   | #python | `61.17% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <0.00%> (ø)` | |
   | [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24uanN4) | `100.00% <ø> (ø)` | |
   | [...end/src/components/Select/SupersetStyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1N1cGVyc2V0U3R5bGVkU2VsZWN0LnRzeA==) | `72.22% <ø> (ø)` | |
   | [...set-frontend/src/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==) | `88.23% <ø> (ø)` | |
   | [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `57.44% <ø> (ø)` | |
   | [...ntend/src/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | `55.55% <ø> (ø)` | |
   | [...end/src/explore/components/ControlPanelSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxTZWN0aW9uLmpzeA==) | `86.36% <ø> (ø)` | |
   | [.../src/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLmpzeA==) | `81.81% <ø> (ø)` | |
   | [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.64% <ø> (ø)` | |
   | [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `69.23% <ø> (ø)` | |
   | ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=footer). Last update [5d08a42...596e47d](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] adam-stasiak closed pull request #10984: chore: Cypress explore visualization tests refactor

Posted by GitBox <gi...@apache.org>.

adam-stasiak closed pull request #10984:
URL: https://github.com/apache/incubator-superset/pull/10984


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10984: chore: Cypress explore visualization tests refactor

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #10984:
URL: https://github.com/apache/incubator-superset/pull/10984#issuecomment-700702583


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=h1) Report
   > Merging [#10984](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5d08a426d30e7e3b32e09541937f466889c2319b?el=desc) will **increase** coverage by `0.37%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10984/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10984      +/-   ##
   ==========================================
   + Coverage   61.17%   61.55%   +0.37%     
   ==========================================
     Files         384      817     +433     
     Lines       24287    38688   +14401     
     Branches        0     3650    +3650     
   ==========================================
   + Hits        14858    23813    +8955     
   - Misses       9429    14695    +5266     
   - Partials        0      180     +180     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.18% <60.00%> (?)` | |
   | #python | `61.17% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <0.00%> (ø)` | |
   | [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24uanN4) | `100.00% <ø> (ø)` | |
   | [...end/src/components/Select/SupersetStyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1N1cGVyc2V0U3R5bGVkU2VsZWN0LnRzeA==) | `72.22% <ø> (ø)` | |
   | [...set-frontend/src/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==) | `88.23% <ø> (ø)` | |
   | [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `57.44% <ø> (ø)` | |
   | [...ntend/src/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | `55.55% <ø> (ø)` | |
   | [...end/src/explore/components/ControlPanelSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxTZWN0aW9uLmpzeA==) | `86.36% <ø> (ø)` | |
   | [.../src/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLmpzeA==) | `81.81% <ø> (ø)` | |
   | [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.64% <ø> (ø)` | |
   | [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `69.23% <ø> (ø)` | |
   | ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/10984/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=footer). Last update [5d08a42...596e47d](https://codecov.io/gh/apache/incubator-superset/pull/10984?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on pull request #10984: chore: Cypress explore visualization tests refactor

Posted by GitBox <gi...@apache.org>.

rusackas commented on pull request #10984:
URL: https://github.com/apache/incubator-superset/pull/10984#issuecomment-703176944


   Looking good... just needs a rebase, and we can merge :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org