[jira] [Commented] (SOLR-13339) ZkController.preClose() prevent recovery, indexfetcher being kicked off after SolrCores already closed

["Cao Manh Dat (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798152#comment-16798152 ] 

Cao Manh Dat commented on SOLR-13339:
-------------------------------------

I attached a patch that introduce the {{ZkController.preClose()}} which is called on start of CC.shutdown() this include
* removeEphemeralLiveNode
* publishNodeAsDown
* ZkCollectionTerms::close
* ReplicateFromLeader::stopReplication
* close electionContexts

> ZkController.preClose() prevent recovery, indexfetcher being kicked off after SolrCores already closed
> ------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-13339
>                 URL: https://issues.apache.org/jira/browse/SOLR-13339
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Cao Manh Dat
>            Assignee: Cao Manh Dat
>            Priority: Major
>         Attachments: SOLR-13339.patch
>
>
> Right now, recovery can be kicked off when SolrCore is already closed or duing closing a SolrCore. It will be more safer to close all event listeners that can kick off recovery or indexfetcher (replicateFromLeader) before we close SolrCores.
> I think it will fix the problem of SOLR-13276 test failures recently.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org