You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/31 08:20:30 UTC
[GitHub] mgaido91 commented on a change in pull request #23701:
[SPARK-26741][SQL] Allow using aggregate expressions in ORDER BY clause
mgaido91 commented on a change in pull request #23701: [SPARK-26741][SQL] Allow using aggregate expressions in ORDER BY clause
URL: https://github.com/apache/spark/pull/23701#discussion_r252569668
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1676,6 +1676,23 @@ class Analyzer(
// just return the original plan.
case ae: AnalysisException => sort
}
+ case sort @ Sort(sortOrders, _, child)
Review comment:
Yes, we can probably collapse them, but it is non-trivial. This is mot likely related to your comment above. I'll try and do that, despite I am not entirely sure about the feasibility, I'll update you if I find some problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org