You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "KesharwaniArpita (via GitHub)" <gi...@apache.org> on 2023/10/10 05:18:19 UTC
[PR] corrected typos in PYPI_README.md [airflow]
KesharwaniArpita opened a new pull request, #34841:
URL: https://github.com/apache/airflow/pull/34841
Corrected some minor grammatical issues in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] corrected typos in PYPI_README.md [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #34841:
URL: https://github.com/apache/airflow/pull/34841#issuecomment-1774778839
Please fix the linter error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] corrected typos in PYPI_README.md [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #34841:
URL: https://github.com/apache/airflow/pull/34841#discussion_r1355153121
##########
generated/PYPI_README.md:
##########
Review Comment:
You should do this in this PR. Ideally you need to change README.md locally and after that run, it will regenerate `PYPI_README.md`
```shell
pre-commit run generate-pypi-readme --all-files
```
or
```shell
breeze static-checks --type generate-pypi-readme --all-files
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] corrected typos in PYPI_README.md [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #34841: corrected typos in PYPI_README.md
URL: https://github.com/apache/airflow/pull/34841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] corrected typos in PYPI_README.md [airflow]
Posted by "KesharwaniArpita (via GitHub)" <gi...@apache.org>.
KesharwaniArpita commented on code in PR #34841:
URL: https://github.com/apache/airflow/pull/34841#discussion_r1355118703
##########
generated/PYPI_README.md:
##########
Review Comment:
Thank you for the feedback.
So, Should I go for the readme.md directly through a new PR?
If that so, what can be done with this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] corrected typos in PYPI_README.md [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #34841:
URL: https://github.com/apache/airflow/pull/34841#issuecomment-1783438602
I see you keep on merging the changes but you have not implemented pre-commit/the explanation from @Taragolis @KesharwaniArpita - this is a bit worrying as something of automation/bot kind of things.
I will close this PR and let you open a new one with the fix in the original README with pre-commit applying it to generated one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] corrected typos in PYPI_README.md [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #34841:
URL: https://github.com/apache/airflow/pull/34841#discussion_r1351921429
##########
generated/PYPI_README.md:
##########
Review Comment:
This file generated from [README.md](https://github.com/apache/airflow/blob/main/README.md) by pre-commit hook [generate-pypi-readme](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#id2), so the changes should be made there in README.md.
Otherwise any further changes in README.md will overwrite you changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org