You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/11 11:28:50 UTC
[GitHub] [skywalking-infra-e2e] kezhenxu94 opened a new pull request #30: Some enhancements
kezhenxu94 opened a new pull request #30:
URL: https://github.com/apache/skywalking-infra-e2e/pull/30
- Cleanup if `cleanup.on == Always` and error happens in `setup` step.
- Fail `setup` step if there is command fail in the `steps.command`.
- Retry per case instead of all cases in `verify` step.
- Delete unused function `Which`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 merged pull request #30: Some enhancements
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #30:
URL: https://github.com/apache/skywalking-infra-e2e/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #30: Some enhancements
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #30:
URL: https://github.com/apache/skywalking-infra-e2e/pull/30#issuecomment-896750214
FYI @mrproliu Please notice these for the document part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] fgksgf commented on a change in pull request #30: Some enhancements
Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #30:
URL: https://github.com/apache/skywalking-infra-e2e/pull/30#discussion_r686743568
##########
File path: commands/run/run.go
##########
@@ -101,3 +90,11 @@ func runAccordingE2E() error {
return nil
}
+
+func cleanup0() {
Review comment:
The function name is confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #30: Some enhancements
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #30:
URL: https://github.com/apache/skywalking-infra-e2e/pull/30#discussion_r686744093
##########
File path: commands/run/run.go
##########
@@ -101,3 +90,11 @@ func runAccordingE2E() error {
return nil
}
+
+func cleanup0() {
Review comment:
> The function name is confusing.
Because `cleanup` is already a package name, or do you prefer something like `doCleanup`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] fgksgf commented on a change in pull request #30: Some enhancements
Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #30:
URL: https://github.com/apache/skywalking-infra-e2e/pull/30#discussion_r686745389
##########
File path: commands/run/run.go
##########
@@ -101,3 +90,11 @@ func runAccordingE2E() error {
return nil
}
+
+func cleanup0() {
Review comment:
That would be better than `cleanup0` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #30: Some enhancements
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #30:
URL: https://github.com/apache/skywalking-infra-e2e/pull/30#discussion_r686746258
##########
File path: commands/run/run.go
##########
@@ -101,3 +90,11 @@ func runAccordingE2E() error {
return nil
}
+
+func cleanup0() {
Review comment:
> That would be better than `cleanup0` :)
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org