You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/05 16:31:46 UTC

[GitHub] mistercrunch closed pull request #6252: [explore] raise attention to row_limit being reached

mistercrunch closed pull request #6252: [explore] raise attention to row_limit being reached
URL: https://github.com/apache/incubator-superset/pull/6252
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/spec/javascripts/explore/components/RowCountLabel_spec.jsx b/superset/assets/spec/javascripts/explore/components/RowCountLabel_spec.jsx
index 761f2e1229..4f06da3e71 100644
--- a/superset/assets/spec/javascripts/explore/components/RowCountLabel_spec.jsx
+++ b/superset/assets/spec/javascripts/explore/components/RowCountLabel_spec.jsx
@@ -20,12 +20,12 @@ describe('RowCountLabel', () => {
     expect(wrapper.find(Label)).toHaveLength(1);
     expect(wrapper.find(TooltipWrapper)).toHaveLength(1);
   });
-  it('renders a warning when limit is reached', () => {
+  it('renders a danger when limit is reached', () => {
     const props = {
       rowcount: 100,
       limit: 100,
     };
     const wrapper = shallow(<RowCountLabel {...props} />);
-    expect(wrapper.find(Label).first().props().bsStyle).toBe('warning');
+    expect(wrapper.find(Label).first().props().bsStyle).toBe('danger');
   });
 });
diff --git a/superset/assets/src/explore/components/RowCountLabel.jsx b/superset/assets/src/explore/components/RowCountLabel.jsx
index 1ba21020fc..aea9bc48ba 100644
--- a/superset/assets/src/explore/components/RowCountLabel.jsx
+++ b/superset/assets/src/explore/components/RowCountLabel.jsx
@@ -20,7 +20,7 @@ const defaultProps = {
 
 export default function RowCountLabel({ rowcount, limit, suffix }) {
   const limitReached = rowcount === limit;
-  const bsStyle = (limitReached || rowcount === 0) ? 'warning' : 'default';
+  const bsStyle = (limitReached || rowcount === 0) ? 'danger' : 'default';
   const formattedRowCount = defaultNumberFormatter(rowcount);
   const tooltip = (
     <span>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org