You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/18 13:27:06 UTC
[GitHub] [flink] danny0405 commented on a change in pull request #10208:
[FLINK-11935][table-planner][table-planner-blink] Remove DateTimeUtils
pull-in and fix datetime casting problem
danny0405 commented on a change in pull request #10208: [FLINK-11935][table-planner][table-planner-blink] Remove DateTimeUtils pull-in and fix datetime casting problem
URL: https://github.com/apache/flink/pull/10208#discussion_r347378773
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/functions/SqlDateTimeUtils.java
##########
@@ -1297,4 +1297,10 @@ private static int parseFraction(String v, int multiplier) {
return r;
}
+ // TODO: remove if CALCITE-3199 fixed
+ // https://issues.apache.org/jira/browse/CALCITE-3199
+ public static long unixDateCeil(TimeUnitRange range, long date) {
+ return julianDateFloor(range, (int) date + EPOCH_JULIAN, false);
Review comment:
Yes, it is, the Julian flag is what CALCITE-3199 fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services