[GitHub] [airflow] msumit commented on a change in pull request #14739: Add files to generate Airflow's Python SDK

[GitBox <gi...@apache.org>]

msumit commented on a change in pull request #14739:
URL: https://github.com/apache/airflow/pull/14739#discussion_r593151902



##########
File path: clients/gen/go.sh
##########
@@ -35,48 +30,11 @@ go_config=(
     "enumClassPrefix=true"
 )
 
-SPEC_PATH=$(realpath "$1")
-readonly SPEC_PATH
-
-if [ ! -d "$2" ]; then
-    echo "$2 is not a valid directory or does not exist."
-    exit 1
-fi
-
-OUTPUT_DIR=$(realpath "$2")
-readonly  OUTPUT_DIR
-
-# create openapi ignore file to keep generated code clean
-cat <<EOF > "${OUTPUT_DIR}/.openapi-generator-ignore"
-.travis.yml
-git_push.sh
-EOF
-
-set -ex
-IFS=','
+validate_input "$@"
 
 gen_client go \
     --package-name airflow \
     --git-repo-id airflow-client-go/airflow \
     --additional-properties "${go_config[*]}"
 
-# patch generated client to support problem HTTP API
-# this patch can be removed after following upstream patch gets merged:
-# https://github.com/OpenAPITools/openapi-generator/pull/6793

Review comment:
       @houqp I see that this patch has been merged in openapi, so I think it should be safe to remove it now, though I'm getting some testcase failures and hoping that it's not related to this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org