You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/02 03:19:22 UTC
[GitHub] [hudi] cuibo01 opened a new pull request #5210: [MINOR] Archive should not skip compaction
cuibo01 opened a new pull request #5210:
URL: https://github.com/apache/hudi/pull/5210
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5210: [MINOR] Archive should not skip compaction
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5210:
URL: https://github.com/apache/hudi/pull/5210#issuecomment-1086532837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49811e447db926e262e380de91795287432c44fb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "49811e447db926e262e380de91795287432c44fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49811e447db926e262e380de91795287432c44fb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5210: [MINOR] Archive should not skip compaction
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5210:
URL: https://github.com/apache/hudi/pull/5210#issuecomment-1086533288
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49811e447db926e262e380de91795287432c44fb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736",
"triggerID" : "49811e447db926e262e380de91795287432c44fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49811e447db926e262e380de91795287432c44fb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5210: [MINOR] Archive should not skip compaction
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5210:
URL: https://github.com/apache/hudi/pull/5210#issuecomment-1086559392
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49811e447db926e262e380de91795287432c44fb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736",
"triggerID" : "49811e447db926e262e380de91795287432c44fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49811e447db926e262e380de91795287432c44fb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] cuibo01 commented on pull request #5210: [MINOR] Archive should not skip compaction
Posted by GitBox <gi...@apache.org>.
cuibo01 commented on pull request #5210:
URL: https://github.com/apache/hudi/pull/5210#issuecomment-1086573159
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5210: [MINOR] Archive should not skip compaction
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5210:
URL: https://github.com/apache/hudi/pull/5210#issuecomment-1086573239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49811e447db926e262e380de91795287432c44fb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736",
"triggerID" : "49811e447db926e262e380de91795287432c44fb",
"triggerType" : "PUSH"
}, {
"hash" : "49811e447db926e262e380de91795287432c44fb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7746",
"triggerID" : "1086573159",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 49811e447db926e262e380de91795287432c44fb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7746)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5210: [MINOR] Archive should not skip compaction
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5210:
URL: https://github.com/apache/hudi/pull/5210#issuecomment-1086573239
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49811e447db926e262e380de91795287432c44fb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736",
"triggerID" : "49811e447db926e262e380de91795287432c44fb",
"triggerType" : "PUSH"
}, {
"hash" : "49811e447db926e262e380de91795287432c44fb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7746",
"triggerID" : "1086573159",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 49811e447db926e262e380de91795287432c44fb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7746)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5210: [MINOR] Archive should not skip compaction
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5210:
URL: https://github.com/apache/hudi/pull/5210#issuecomment-1086559392
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49811e447db926e262e380de91795287432c44fb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736",
"triggerID" : "49811e447db926e262e380de91795287432c44fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49811e447db926e262e380de91795287432c44fb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #5210: [MINOR] Archive should not skip compaction
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #5210:
URL: https://github.com/apache/hudi/pull/5210#discussion_r841061457
##########
File path: hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java
##########
@@ -256,8 +256,8 @@ public Result inputSplits(
HoodieTimeline archivedCompleteTimeline = archivedTimeline.getCommitsTimeline().filterCompletedInstants();
if (!archivedCompleteTimeline.empty()) {
Stream<HoodieInstant> instantStream = archivedCompleteTimeline.getInstants();
- return maySkipCompaction(instantStream)
- .map(instant -> WriteProfiles.getCommitMetadata(tableName, path, instant, archivedTimeline)).collect(Collectors.toList());
+ return instantStream.map(instant -> WriteProfiles.getCommitMetadata(tableName, path, instant, archivedTimeline))
+ .collect(Collectors.toList());
Review comment:
You mean for incremental read, the user does not need to read the change log (or only snapshot is needed) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5210: [MINOR] Archive should not skip compaction
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5210:
URL: https://github.com/apache/hudi/pull/5210#issuecomment-1086533288
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49811e447db926e262e380de91795287432c44fb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736",
"triggerID" : "49811e447db926e262e380de91795287432c44fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49811e447db926e262e380de91795287432c44fb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5210: [MINOR] Archive should not skip compaction
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5210:
URL: https://github.com/apache/hudi/pull/5210#issuecomment-1086532837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49811e447db926e262e380de91795287432c44fb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "49811e447db926e262e380de91795287432c44fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49811e447db926e262e380de91795287432c44fb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5210: [MINOR] Archive should not skip compaction
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5210:
URL: https://github.com/apache/hudi/pull/5210#issuecomment-1086607720
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49811e447db926e262e380de91795287432c44fb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736",
"triggerID" : "49811e447db926e262e380de91795287432c44fb",
"triggerType" : "PUSH"
}, {
"hash" : "49811e447db926e262e380de91795287432c44fb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7746",
"triggerID" : "1086573159",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 49811e447db926e262e380de91795287432c44fb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7736) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7746)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org