You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Daniel Oliveira (JIRA)" <ji...@apache.org> on 2018/03/22 23:02:01 UTC

[jira] [Resolved] (BEAM-419) Non-transient non-serializable instance field in CombineFnUtil$NonSerializableBoundedKeyedCombineFn

     [ https://issues.apache.org/jira/browse/BEAM-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Oliveira resolved BEAM-419.
----------------------------------
       Resolution: Invalid
    Fix Version/s: Not applicable

The findbug issue turned out to be a inapplicable, the class was technically serializable, but was non-serializable by throwing exceptions if it tried to be serialized. So there was no problem having a non-serializable field in the class.

I replaced the reference to this issue in the xml file with a comment explaining why it should be ignored.

> Non-transient non-serializable instance field in CombineFnUtil$NonSerializableBoundedKeyedCombineFn
> ---------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-419
>                 URL: https://issues.apache.org/jira/browse/BEAM-419
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Assignee: Daniel Oliveira
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>             Fix For: Not applicable
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> [FindBugs SE_BAD_FIELD|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L363]: Non-transient non-serializable instance field in serializable class
> Applies to: [CombineFnUtil$NonSerializableBoundedKeyedCombineFn.context|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CombineFnUtil.java#L170].
> This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)