[GitHub] [tvm] masahi commented on a diff in pull request #11341: [TE] Optimized version of concatenation layer

[GitBox <gi...@apache.org>]

masahi commented on code in PR #11341:
URL: https://github.com/apache/tvm/pull/11341#discussion_r886388673


##########
src/te/schedule/schedule_dataflow_rewrite.cc:
##########
@@ -511,6 +511,29 @@ void InjectInline(ScheduleNode* sch, bool feature_extraction_mode) {
   std::vector<bool> changed(sch->stages.size(), false);
   std::vector<Stmt> new_hybrid_body(sch->stages.size());
   std::vector<bool> hybrid_changed(sch->stages.size(), false);
+  // (sshtin): this workaround allows to inline extern ops.
+  // All inputs for extern op should not be inlined because inlining happens
+  // before generation of TE script for particular extern op. That may lead to

Review Comment:
   How about simply dropping `script`? I don't think "TE script" is a common term. And "generation of TE" sounds ok. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org