You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/28 04:13:08 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #685: Support GitHub mirrors in CMake build configurations
PragmaTwice opened a new pull request, #685:
URL: https://github.com/apache/incubator-kvrocks/pull/685
Close #622.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun merged pull request #685: Support GitHub mirrors in CMake build configurations
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #685:
URL: https://github.com/apache/incubator-kvrocks/pull/685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #685: Support GitHub mirrors in CMake build configurations
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #685:
URL: https://github.com/apache/incubator-kvrocks/pull/685#discussion_r908442461
##########
README.md:
##########
@@ -102,8 +102,10 @@ $ ./unittest
### Supported platforms
-* CentOS 6 or 7
-* Ubuntu
+* Linux distributions
+ * CentOS 6 or 7
+ * Ubuntu
+ * and most other distros
Review Comment:
I'm OK with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #685: Support GitHub mirrors in CMake build configurations
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #685:
URL: https://github.com/apache/incubator-kvrocks/pull/685#issuecomment-1168780924
> We may need to find some queuing strategy to reduce update branch overhead :P
I think we also can use ccache and actions/cache to reduce build time by incremental build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #685: Support GitHub mirrors in CMake build configurations
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #685:
URL: https://github.com/apache/incubator-kvrocks/pull/685#issuecomment-1168671280
> LGTM. @PragmaTwice I think we can add a short section in README.md for consumers of this feature.
Thanks, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #685: Support GitHub mirrors in CMake build configurations
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #685:
URL: https://github.com/apache/incubator-kvrocks/pull/685#discussion_r908441969
##########
README.md:
##########
@@ -68,7 +68,7 @@ It is as simple as:
```shell
$ git clone https://github.com/apache/incubator-kvrocks.git
$ cd incubator-kvrocks
-$ ./build.sh build # `./build.sh -h` to check more options
+$ ./build.sh build # `./build.sh -h` to check more options, and `--ghproxy` is recommanded for chinese users
Review Comment:
```suggestion
$ ./build.sh build # `./build.sh -h` to check more options;
# especially, `./build.sh build --ghproxy` will fetch dependencies via ghproxy.com.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #685: Support GitHub mirrors in CMake build configurations
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on code in PR #685:
URL: https://github.com/apache/incubator-kvrocks/pull/685#discussion_r908435681
##########
README.md:
##########
@@ -102,8 +102,10 @@ $ ./unittest
### Supported platforms
-* CentOS 6 or 7
-* Ubuntu
+* Linux distributions
+ * CentOS 6 or 7
+ * Ubuntu
+ * and most other distros
Review Comment:
Some other changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #685: Support GitHub mirrors in CMake build configurations
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on code in PR #685:
URL: https://github.com/apache/incubator-kvrocks/pull/685#discussion_r908435681
##########
README.md:
##########
@@ -102,8 +102,10 @@ $ ./unittest
### Supported platforms
-* CentOS 6 or 7
-* Ubuntu
+* Linux distributions
+ * CentOS 6 or 7
+ * Ubuntu
+ * and most other distros
Review Comment:
Some other changes, not sure whether should move to seperate PR.
##########
README.md:
##########
@@ -102,8 +102,10 @@ $ ./unittest
### Supported platforms
-* CentOS 6 or 7
-* Ubuntu
+* Linux distributions
+ * CentOS 6 or 7
+ * Ubuntu
+ * and most other distros
Review Comment:
Some other changes, not sure whether should move to a seperate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #685: Support GitHub mirrors in CMake build configurations
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #685:
URL: https://github.com/apache/incubator-kvrocks/pull/685#issuecomment-1168775483
We may need to find some queuing strategy to reduce update branch overhead :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org