You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "unbridled-41 (via GitHub)" <gi...@apache.org> on 2026/10/09 21:03:52 UTC
[PR] fix(metrics): scope the explorer query history to the signed-in account [rocketmq-dashboard]
unbridled-41 opened a new pull request, #5983:
URL: https://github.com/apache/rocketmq-dashboard/pull/5983
### Which Issue(s) This PR Fixes
Fixes #5982
### Problem / Evidence
`METRICS_QUERY_HISTORY_STORAGE_KEY` was one global key; `authStorage.clearAuthSession` removes only the token/user keys, so the history survived a logout:
```
metricsExplorerDiagnostics: does not hand one account the query history of another
AssertionError: expected [ { ...(17) } ] to deeply equal []
```
(with an unscoped key; the entry is rendered in the drawer and re-runnable).
### Root cause / Fix
Account-scoped data under an account-independent key. Derive the key from the signed-in account (user id, else the username, else `anonymous`) and export the key builder so the panel's tests seed and assert against the current account's store.
### Priority and scoring
**PRIORITY 55** - impact 20/40 (cross-account disclosure of query content), blast radius 10/20 (shared browsers), reproducibility 18/20 (pinned by the new test), maintenance value 4/20. **FIX_CONFIDENCE 75**.
### Tests
`cd web && npx vitest run src/utils/metricsExplorerDiagnostics.test.ts src/components/__tests__/MetricsExplorer.test.tsx` -> `Tests 46 passed`; the new case fails with an unscoped key and passes with the scoped one; the six explorer cases that seeded the raw key now use the exported builder; `npx eslint` and `npx tsc -b` pass.
### Risk
A history written before this change is not visible after it (the key changes) - acceptable for scratch history, and the same trade the account-scoping work elsewhere makes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metrics): scope the explorer query history to the signed-in account [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5983:
URL: https://github.com/apache/rocketmq-dashboard/pull/5983#issuecomment-6227218053
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metrics): scope the explorer query history to the signed-in account [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #5983:
URL: https://github.com/apache/rocketmq-dashboard/pull/5983#issuecomment-6090235153
### CI status of this PR
`Backend Tests (Java 21)` — see the note below the list.
The four remaining red jobs are red for every branch, including `rocketmq-studio` itself:
- `Backend Build (Java 21)` — the `binary-license-gate` antrun step fails on a list of third-party jars (`spring-ai-*`, `swagger-ui`, `tencentcloud-sdk-*`, `zstd-jni`, ... : "missing complete upstream LICENSE/COPYING; a POM name or link is not a substitute"). This PR touches no build configuration; tracked by #5341.
- `Frontend Build (Node 20)` / `Frontend Docker Build` — the frontend licence manifest check fails the same way on branches that do not touch `web/` at all; tracked by #5346.
- `rmqctl Build (Go)` — `cmd` `TestMessageQueryCompletenessWarningTest` yaml subtests: `got {"items":[{"size":"3",...}]}, want {"size":3,...}`, i.e. the YAML renderer writes numbers as quoted strings where the test expects integer literals. Reproduced locally with `cd rmqctl && go test ./cmd/` from a checkout whose `rmqctl/` tree is byte-identical to `rocketmq-studio`'s, and owned by open PR #5850 ("keep yaml numbers unquoted").
`Backend Tests (Java 21)` failure attribution: `ResourceOwnershipGuardTest.migrationConcurrentStartupIsIdempotentTest` — `org.h2.jdbc.JdbcSQLNonTransientException: General error: java.util.ConcurrentModificationException` — the known flaky H2 concurrency test tracked by #5302. It reproduces independently of this diff (which touches no persistence code) and the same job passes on sibling PRs of the same batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metrics): scope the explorer query history to the signed-in account [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #5983:
URL: https://github.com/apache/rocketmq-dashboard/pull/5983#issuecomment-6091396899
### Verification on the final commit (branch + commit + command results)
Every command from the description re-run on a fresh worktree of this branch (`git worktree add <dir> fork/<branch>`, no local modifications), at commit `0b93666b8b`:
| command | exit | result |
| --- | --- | --- |
| `cd web && npx vitest run src/utils/metricsExplorerDiagnostics.test.ts src/components/__tests__/MetricsExplorer.test.tsx` | 0 | `Test Files 2 passed (2) · Tests 46 passed (46)` |
CI note: on this repository the `Backend Build` (binary-license-gate), `Frontend Build` / `Frontend Docker Build` (licence manifest) and `rmqctl Build` (YAML renderer quoting) jobs are red for every branch, trunk included; the module-level commands above are unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metrics): scope the explorer query history to the signed-in account [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5983: fix(metrics): scope the explorer query history to the signed-in account
URL: https://github.com/apache/rocketmq-dashboard/pull/5983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org