[GitHub] jiangphcn commented on a change in pull request #1085: Return update_seq and offset when update_seq is true and keys is set

[GitBox <gi...@apache.org>]

jiangphcn commented on a change in pull request #1085: Return update_seq and offset when update_seq is true and keys is set
URL: https://github.com/apache/couchdb/pull/1085#discussion_r161421795
 
 

 ##########
 File path: src/fabric/src/fabric_view_all_docs.erl
 ##########
 @@ -59,7 +59,8 @@ go(DbName, Options, QueryArgs, Callback, Acc0) ->
         conflicts = Conflicts,
         skip = Skip,
         keys = Keys0,
-        extra = Extra
+        extra = Extra,
+        update_seq = UpdateSeq
 
 Review comment:
   Thanks @iilyak. However, wants to double check with you whether we need two commits. Actually, the definition for `mrargs` was not changed. https://github.com/apache/couchdb/blob/master/src/couch_mrview/include/couch_mrview.hrl#L86.  The `update_seq` filed was already present in any nodes in mixed cluster. In my newly introduced codes,  the value of `update_seq` field is fetched here and used to check whether we need to return update_seq value or not. If request is sent to nodes which are not upgraded, update_seq information is not returned. Otherwise, for upgraded nodes, the update_seq information will be returned. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services