You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Yunze Xu <xy...@apache.org> on 2023/11/07 07:03:37 UTC

[VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

This is the second release candidate for Apache Pulsar Client C++,
version 3.4.0.

It fixes the following issues:
https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1

*** Please download, test and vote on this release. This vote will stay open
for at least 72 hours ***

Note that we are voting upon the source (tag), binaries are provided for
convenience.

Source and binary files:
https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/

SHA-512 checksums:

10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950
 apache-pulsar-client-cpp-3.4.0.tar.gz


The tag to be voted upon:
v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70)
https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2

Pulsar's KEYS file containing PGP keys you use to sign the release:
https://downloads.apache.org/pulsar/KEYS

Please download the source package, and follow the README to compile and test.

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

Posted by Yunze Xu <xy...@apache.org>.
Closing this vote by 3 binding +1s:

- Penghui
- Yunze
- Mattison

Thanks,
Yunze


On Mon, Nov 13, 2023 at 11:14 AM Yunze Xu <xy...@apache.org> wrote:
>
> In addition to Mattison's failure. The
> `LookupServiceTest.testMultiAddresses` failed because the HTTP proxy
> is enabled. See https://github.com/apache/pulsar-client-cpp/issues/343
>
> In addition, I edited the wiki to note proxy should be disabled
> because many failed tests could be caused by the proxy:
> https://github.com/apache/pulsar-client-cpp/wiki/Committer-Release-Guide#run-the-vote
>
> Thanks,
> Yunze
>
> On Mon, Nov 13, 2023 at 10:05 AM mattison chao <ma...@gmail.com> wrote:
> >
> > +1(binding)
> >
> > Some failing tests are unstable and state-dependent, and the test passes after retrying.
> >
> >
> > Best,
> > Mattison
> >
> > > On Nov 12, 2023, at 22:10, mattison chao <ma...@gmail.com> wrote:
> > >
> > > Hi, Yunze
> > >
> > > I’ve got several failed tests.
> > >
> > > [----------] Global test environment tear-down
> > > [==========] 528 tests from 85 test suites ran. (888193 ms total)
> > > [  PASSED  ] 525 tests.
> > > [  FAILED  ] 3 tests, listed below:
> > > [  FAILED  ] CustomLoggerTest.testCustomLogger
> > > [  FAILED  ] LookupServiceTest.testMultiAddresses
> > > [  FAILED  ] c_ConsumerTest.testCDeadLetterTopic
> > >
> > >
> > > After rerun, the second and third tests still failed.
> > >
> > > /Users/mattisonchao/projects/apache/pulsar-client-cpp/tests/c/c_ConsumerTest.cc:182: Failure
> > > Expected equality of these values:
> > >   pulsar_result_Timeout
> > >     Which is: 3
> > >   res
> > >     Which is: 0
> > >
> > > [  FAILED  ] c_ConsumerTest.testCDeadLetterTopic (75 ms)
> > > [----------] 1 test from c_ConsumerTest (75 ms total)
> > >
> > > [----------] Global test environment tear-down
> > > [==========] 1 test from 1 test suite ran. (75 ms total)
> > > [  PASSED  ] 0 tests.
> > > [  FAILED  ] 1 test, listed below:
> > > [  FAILED  ] c_ConsumerTest.testCDeadLetterTopic
> > >
> > >
> > > Expected equality of these values:
> > >   std::count(results.cbegin(), results.cend(), ResultRetryable)
> > >     Which is: 0
> > >   numRequests / 2
> > >     Which is: 3
> > >
> > > 2023-11-12 22:10:03.538 INFO  [0x1e483d300] ClientConnection:268 | [<none> -> pulsar://localhost:9999] Destroyed connection to pulsar://localhost:9999
> > > [  FAILED  ] LookupServiceTest.testMultiAddresses (89 ms)
> > > [----------] 1 test from LookupServiceTest (89 ms total)
> > >
> > > [----------] Global test environment tear-down
> > > [==========] 1 test from 1 test suite ran. (89 ms total)
> > > [  PASSED  ] 0 tests.
> > > [  FAILED  ] 1 test, listed below:
> > > [  FAILED  ] LookupServiceTest.testMultiAddresses
> > >
> > >
> > >
> > > Best,
> > > Mattison
> > >
> > >> On Nov 7, 2023, at 15:03, Yunze Xu <xy...@apache.org> wrote:
> > >>
> > >> This is the second release candidate for Apache Pulsar Client C++,
> > >> version 3.4.0.
> > >>
> > >> It fixes the following issues:
> > >> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1
> > >>
> > >> *** Please download, test and vote on this release. This vote will stay open
> > >> for at least 72 hours ***
> > >>
> > >> Note that we are voting upon the source (tag), binaries are provided for
> > >> convenience.
> > >>
> > >> Source and binary files:
> > >> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
> > >>
> > >> SHA-512 checksums:
> > >>
> > >> 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950
> > >> apache-pulsar-client-cpp-3.4.0.tar.gz
> > >>
> > >>
> > >> The tag to be voted upon:
> > >> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70)
> > >> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2
> > >>
> > >> Pulsar's KEYS file containing PGP keys you use to sign the release:
> > >> https://downloads.apache.org/pulsar/KEYS
> > >>
> > >> Please download the source package, and follow the README to compile and test.
> > >
> >

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

Posted by Yunze Xu <xy...@apache.org>.
In addition to Mattison's failure. The
`LookupServiceTest.testMultiAddresses` failed because the HTTP proxy
is enabled. See https://github.com/apache/pulsar-client-cpp/issues/343

In addition, I edited the wiki to note proxy should be disabled
because many failed tests could be caused by the proxy:
https://github.com/apache/pulsar-client-cpp/wiki/Committer-Release-Guide#run-the-vote

Thanks,
Yunze

On Mon, Nov 13, 2023 at 10:05 AM mattison chao <ma...@gmail.com> wrote:
>
> +1(binding)
>
> Some failing tests are unstable and state-dependent, and the test passes after retrying.
>
>
> Best,
> Mattison
>
> > On Nov 12, 2023, at 22:10, mattison chao <ma...@gmail.com> wrote:
> >
> > Hi, Yunze
> >
> > I’ve got several failed tests.
> >
> > [----------] Global test environment tear-down
> > [==========] 528 tests from 85 test suites ran. (888193 ms total)
> > [  PASSED  ] 525 tests.
> > [  FAILED  ] 3 tests, listed below:
> > [  FAILED  ] CustomLoggerTest.testCustomLogger
> > [  FAILED  ] LookupServiceTest.testMultiAddresses
> > [  FAILED  ] c_ConsumerTest.testCDeadLetterTopic
> >
> >
> > After rerun, the second and third tests still failed.
> >
> > /Users/mattisonchao/projects/apache/pulsar-client-cpp/tests/c/c_ConsumerTest.cc:182: Failure
> > Expected equality of these values:
> >   pulsar_result_Timeout
> >     Which is: 3
> >   res
> >     Which is: 0
> >
> > [  FAILED  ] c_ConsumerTest.testCDeadLetterTopic (75 ms)
> > [----------] 1 test from c_ConsumerTest (75 ms total)
> >
> > [----------] Global test environment tear-down
> > [==========] 1 test from 1 test suite ran. (75 ms total)
> > [  PASSED  ] 0 tests.
> > [  FAILED  ] 1 test, listed below:
> > [  FAILED  ] c_ConsumerTest.testCDeadLetterTopic
> >
> >
> > Expected equality of these values:
> >   std::count(results.cbegin(), results.cend(), ResultRetryable)
> >     Which is: 0
> >   numRequests / 2
> >     Which is: 3
> >
> > 2023-11-12 22:10:03.538 INFO  [0x1e483d300] ClientConnection:268 | [<none> -> pulsar://localhost:9999] Destroyed connection to pulsar://localhost:9999
> > [  FAILED  ] LookupServiceTest.testMultiAddresses (89 ms)
> > [----------] 1 test from LookupServiceTest (89 ms total)
> >
> > [----------] Global test environment tear-down
> > [==========] 1 test from 1 test suite ran. (89 ms total)
> > [  PASSED  ] 0 tests.
> > [  FAILED  ] 1 test, listed below:
> > [  FAILED  ] LookupServiceTest.testMultiAddresses
> >
> >
> >
> > Best,
> > Mattison
> >
> >> On Nov 7, 2023, at 15:03, Yunze Xu <xy...@apache.org> wrote:
> >>
> >> This is the second release candidate for Apache Pulsar Client C++,
> >> version 3.4.0.
> >>
> >> It fixes the following issues:
> >> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1
> >>
> >> *** Please download, test and vote on this release. This vote will stay open
> >> for at least 72 hours ***
> >>
> >> Note that we are voting upon the source (tag), binaries are provided for
> >> convenience.
> >>
> >> Source and binary files:
> >> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
> >>
> >> SHA-512 checksums:
> >>
> >> 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950
> >> apache-pulsar-client-cpp-3.4.0.tar.gz
> >>
> >>
> >> The tag to be voted upon:
> >> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70)
> >> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2
> >>
> >> Pulsar's KEYS file containing PGP keys you use to sign the release:
> >> https://downloads.apache.org/pulsar/KEYS
> >>
> >> Please download the source package, and follow the README to compile and test.
> >
>

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

Posted by mattison chao <ma...@gmail.com>.
+1(binding)

Some failing tests are unstable and state-dependent, and the test passes after retrying.


Best,
Mattison

> On Nov 12, 2023, at 22:10, mattison chao <ma...@gmail.com> wrote:
> 
> Hi, Yunze
> 
> I’ve got several failed tests.
> 
> [----------] Global test environment tear-down
> [==========] 528 tests from 85 test suites ran. (888193 ms total)
> [  PASSED  ] 525 tests.
> [  FAILED  ] 3 tests, listed below:
> [  FAILED  ] CustomLoggerTest.testCustomLogger
> [  FAILED  ] LookupServiceTest.testMultiAddresses
> [  FAILED  ] c_ConsumerTest.testCDeadLetterTopic
> 
> 
> After rerun, the second and third tests still failed.
> 
> /Users/mattisonchao/projects/apache/pulsar-client-cpp/tests/c/c_ConsumerTest.cc:182: Failure
> Expected equality of these values:
>   pulsar_result_Timeout
>     Which is: 3
>   res
>     Which is: 0
> 
> [  FAILED  ] c_ConsumerTest.testCDeadLetterTopic (75 ms)
> [----------] 1 test from c_ConsumerTest (75 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test suite ran. (75 ms total)
> [  PASSED  ] 0 tests.
> [  FAILED  ] 1 test, listed below:
> [  FAILED  ] c_ConsumerTest.testCDeadLetterTopic
> 
> 
> Expected equality of these values:
>   std::count(results.cbegin(), results.cend(), ResultRetryable)
>     Which is: 0
>   numRequests / 2
>     Which is: 3
> 
> 2023-11-12 22:10:03.538 INFO  [0x1e483d300] ClientConnection:268 | [<none> -> pulsar://localhost:9999] Destroyed connection to pulsar://localhost:9999
> [  FAILED  ] LookupServiceTest.testMultiAddresses (89 ms)
> [----------] 1 test from LookupServiceTest (89 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test suite ran. (89 ms total)
> [  PASSED  ] 0 tests.
> [  FAILED  ] 1 test, listed below:
> [  FAILED  ] LookupServiceTest.testMultiAddresses
> 
> 
> 
> Best,
> Mattison
> 
>> On Nov 7, 2023, at 15:03, Yunze Xu <xy...@apache.org> wrote:
>> 
>> This is the second release candidate for Apache Pulsar Client C++,
>> version 3.4.0.
>> 
>> It fixes the following issues:
>> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1
>> 
>> *** Please download, test and vote on this release. This vote will stay open
>> for at least 72 hours ***
>> 
>> Note that we are voting upon the source (tag), binaries are provided for
>> convenience.
>> 
>> Source and binary files:
>> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
>> 
>> SHA-512 checksums:
>> 
>> 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950
>> apache-pulsar-client-cpp-3.4.0.tar.gz
>> 
>> 
>> The tag to be voted upon:
>> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70)
>> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2
>> 
>> Pulsar's KEYS file containing PGP keys you use to sign the release:
>> https://downloads.apache.org/pulsar/KEYS
>> 
>> Please download the source package, and follow the README to compile and test.
> 


Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

Posted by mattison chao <ma...@gmail.com>.
Hi, Yunze

I’ve got several failed tests.

[----------] Global test environment tear-down
[==========] 528 tests from 85 test suites ran. (888193 ms total)
[  PASSED  ] 525 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] CustomLoggerTest.testCustomLogger
[  FAILED  ] LookupServiceTest.testMultiAddresses
[  FAILED  ] c_ConsumerTest.testCDeadLetterTopic


After rerun, the second and third tests still failed.

/Users/mattisonchao/projects/apache/pulsar-client-cpp/tests/c/c_ConsumerTest.cc:182: Failure
Expected equality of these values:
  pulsar_result_Timeout
    Which is: 3
  res
    Which is: 0

[  FAILED  ] c_ConsumerTest.testCDeadLetterTopic (75 ms)
[----------] 1 test from c_ConsumerTest (75 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (75 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] c_ConsumerTest.testCDeadLetterTopic


Expected equality of these values:
  std::count(results.cbegin(), results.cend(), ResultRetryable)
    Which is: 0
  numRequests / 2
    Which is: 3

2023-11-12 22:10:03.538 INFO  [0x1e483d300] ClientConnection:268 | [<none> -> pulsar://localhost:9999] Destroyed connection to pulsar://localhost:9999
[  FAILED  ] LookupServiceTest.testMultiAddresses (89 ms)
[----------] 1 test from LookupServiceTest (89 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (89 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] LookupServiceTest.testMultiAddresses



Best,
Mattison

> On Nov 7, 2023, at 15:03, Yunze Xu <xy...@apache.org> wrote:
> 
> This is the second release candidate for Apache Pulsar Client C++,
> version 3.4.0.
> 
> It fixes the following issues:
> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1
> 
> *** Please download, test and vote on this release. This vote will stay open
> for at least 72 hours ***
> 
> Note that we are voting upon the source (tag), binaries are provided for
> convenience.
> 
> Source and binary files:
> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
> 
> SHA-512 checksums:
> 
> 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950
> apache-pulsar-client-cpp-3.4.0.tar.gz
> 
> 
> The tag to be voted upon:
> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70)
> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2
> 
> Pulsar's KEYS file containing PGP keys you use to sign the release:
> https://downloads.apache.org/pulsar/KEYS
> 
> Please download the source package, and follow the README to compile and test.


Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

Posted by PengHui Li <pe...@apache.org>.
+1 (binding)

- Checked the signature
- Build from source and run the tests

Regards,
Penghui

On Thu, Nov 9, 2023 at 5:15 PM Yunze Xu <xy...@apache.org> wrote:

> +1 (binding)
>
> - Verified checksum and signatures
> - Built from source and run unit tests against the test standalone on
> macOS Ventura 13.4 and Apple Clang 14.0.3
>
> A tip for the failed LookupServiceTest.testMultiAddresses I mentioned
> before, it's because this test has a too strict requirement that the
> localhost should be mapped to 127.0.0.1, while on my macOS localhost
> was mapped to IPv6 ::1 first. The test passed after I modified the
> /etc/hosts file.
>
> Thanks,
> Yunze
>
> On Thu, Nov 9, 2023 at 11:42 AM Yunze Xu <xy...@apache.org> wrote:
> >
> > Hi Penghui,
> >
> > It's caused by the relative path and I explained it that issue. Here
> > is an improvement for tests:
> > https://github.com/apache/pulsar-client-cpp/pull/340.
> >
> > Thanks,
> > Yunze
>

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

Posted by Yunze Xu <xy...@apache.org>.
+1 (binding)

- Verified checksum and signatures
- Built from source and run unit tests against the test standalone on
macOS Ventura 13.4 and Apple Clang 14.0.3

A tip for the failed LookupServiceTest.testMultiAddresses I mentioned
before, it's because this test has a too strict requirement that the
localhost should be mapped to 127.0.0.1, while on my macOS localhost
was mapped to IPv6 ::1 first. The test passed after I modified the
/etc/hosts file.

Thanks,
Yunze

On Thu, Nov 9, 2023 at 11:42 AM Yunze Xu <xy...@apache.org> wrote:
>
> Hi Penghui,
>
> It's caused by the relative path and I explained it that issue. Here
> is an improvement for tests:
> https://github.com/apache/pulsar-client-cpp/pull/340.
>
> Thanks,
> Yunze

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

Posted by Yunze Xu <xy...@apache.org>.
Hi Penghui,

It's caused by the relative path and I explained it that issue. Here
is an improvement for tests:
https://github.com/apache/pulsar-client-cpp/pull/340.

Thanks,
Yunze

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

Posted by PengHui Li <pe...@apache.org>.
Hi Yunze,

Thanks for the reminder. I enabled the proxy on my laptop.
After disabling the proxy, the timeout issue is gone.

Now, all the tests get passed except two consistently failed tests related
to the token test.

I have created a GitHub issue.

https://github.com/apache/pulsar-client-cpp/issues/339

Thanks,
Penghui

On Thu, Nov 9, 2023 at 1:33 AM Yunze Xu <xy...@apache.org> wrote:

> I think it's caused by the ClientTest.testConnectTimeout. The
> resources seem not cleaned well in this test so it affected the tests
> later. Could you try the following command that ignores this test?
>
> ```bash
> ./pulsar-tests  --gtest_filter='-ClientTest.testConnectTimeout'
> ```
>
> If the rest of the tests pass, you can open an issue to track this
> flaky test. And I see the local host is "198.18.0.1", did you use any
> proxy when running the tests?
>
>
> > Is it possible to install the CPP client without building from the
> source code?
>
> Currently there is no "true" way to avoid building from source. You
> can edit the libpulsar ruby file to install the 3.4.0-candidate-2 (See
>
> https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md#to-contribute-a-fix-to-the-foo-formula
> )
> but it still builds from source. The only advantage is that all 3rd
> party dependencies are guaranteed to be installed from homebrew..
> Maybe we can add a workflow to upload the pre-built libraries for
> macOS in future.
>
> ----
>
> BTW, I ran the `pulsar-tests` locally and it failed with two tests:
>
> ```
> [  FAILED  ] 2 tests, listed below:
> [  FAILED  ] CustomLoggerTest.testCustomLogger
> [  FAILED  ] LookupServiceTest.testMultiAddresses
> ```
>
> These tests seem flaky so I reran them individually by:
>
> ```
> ./tests/pulsar-tests --gtest_filter='CustomLoggerTest.*'
> ./tests/pulsar-tests --gtest_filter='*testMultiAddresses'
> ```
>
> `LookupServiceTest.testMultiAddresses` still failed. I will take a look
> soon.
>
> Thanks,
> Yunze
>
>
> On Wed, Nov 8, 2023 at 11:07 PM PengHui Li <pe...@apache.org> wrote:
> >
> > Hi Yunze,
> >
> > I got an error when running the pulsar-tests (I tried multiple times,
> same
> > error)
> >
> > ```
> > 2023-11-08 22:56:43.676 INFO  [0x16db63000] ProducerImpl:216 |
> >
> [persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1,
> > ] Created producer on broker [[::1]:58479 -> [::1]:6650]
> > 2023-11-08 22:56:43.693 INFO  [0x1f086e080] ProducerImpl:791 |
> >
> [persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-0,
> > standalone-0-635] Closing producer for topic
> >
> persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-0
> > 2023-11-08 22:56:43.693 INFO  [0x1f086e080] ProducerImpl:791 |
> >
> [persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1,
> > standalone-0-636] Closing producer for topic
> >
> persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1
> > 2023-11-08 22:56:43.693 INFO  [0x16db63000] ProducerImpl:755 |
> >
> [persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-0,
> > standalone-0-635] Closed producer 0
> > 2023-11-08 22:56:43.693 INFO  [0x16db63000] ProducerImpl:755 |
> >
> [persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1,
> > standalone-0-636] Closed producer 1
> > 2023-11-08 22:56:44.773 WARN  [0x16ba07000] ConnectionPool:91 | Deleting
> > stale connection from pool for pulsar://192.0.2.1:1234-0 use_count: 1 @
> > 0x13000ea00
> > 2023-11-08 22:56:44.773 INFO  [0x16ba07000] ClientConnection:268 | [
> > 198.18.0.1:58467 -> 192.0.2.1:1234] Destroyed connection to pulsar://
> > 192.0.2.1:1234
> > 2023-11-08 22:56:44.773 INFO  [0x16ba07000] ClientConnection:188 |
> [<none>
> > -> pulsar://192.0.2.1:1234] Create ClientConnection, timeout=1000
> > 2023-11-08 22:56:44.773 INFO  [0x16ba07000] ConnectionPool:109 | Created
> > connection for pulsar://192.0.2.1:1234
> > 2023-11-08 22:56:44.775 INFO  [0x16ba07000] ClientConnection:398 | [
> > 198.18.0.1:58482 -> 192.0.2.1:1234] Connected to broker
> > 2023-11-08 22:56:45.774 ERROR [0x16ba07000] ClientConnection:612 | [
> > 198.18.0.1:58482 -> 192.0.2.1:1234] Connection was not established in
> 1000
> > ms, close the socket
> > 2023-11-08 22:56:45.775 INFO  [0x16ba07000] ClientConnection:1319 | [
> > 198.18.0.1:58482 -> 192.0.2.1:1234] Connection disconnected (refCnt: 2)
> > 2023-11-08 22:56:45.775 ERROR [0x16ba07000] ClientImpl:199 | Error
> > Checking/Getting Partition Metadata while creating producer on
> > persistent://public/default/test-connect-timeout -- TimeOut
> > zsh: segmentation fault  ./pulsar-tests
> > ```
> >
> > Reproduce steps:
> >
> > - Build from downloaded source code (passed)
> > - Start pulsar service (./pulsar-test-service-start.sh)
> > - Run the test(./pulsar-tests)
> >
> > Then, I got the above errors after a few minutes.
> > I'm not sure it's just a test issue or not.
> >
> > One more question:
> >
> > Is it possible to install the CPP client without building from the source
> > code?
> > From
> >
> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
> > I can find the package for Linux and Windows. But no package for macOS.
> >
> > Regards,
> > Penghui
> >
> > On Wed, Nov 8, 2023 at 10:45 PM Yubiao Feng
> > <yu...@streamnative.io.invalid> wrote:
> >
> > > Hi all
> > >
> > > Sorry, I'll send another email explaining what tests were done.
> > >
> > > Please ignore the previous email.
> > >
> > > Thanks
> > > Yubiao Feng
> > >
> > >
> > > On Wed, Nov 8, 2023 at 11:48 AM Yubiao Feng <
> yubiao.feng@streamnative.io>
> > > wrote:
> > >
> > > > +1 (no-binding)
> > > >
> > > > Thanks
> > > > Yubiao Feng
> > > >
> > > > On Tue, Nov 7, 2023 at 3:03 PM Yunze Xu <xy...@apache.org> wrote:
> > > >
> > > >> This is the second release candidate for Apache Pulsar Client C++,
> > > >> version 3.4.0.
> > > >>
> > > >> It fixes the following issues:
> > > >> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1
> > > >>
> > > >> *** Please download, test and vote on this release. This vote will
> stay
> > > >> open
> > > >> for at least 72 hours ***
> > > >>
> > > >> Note that we are voting upon the source (tag), binaries are
> provided for
> > > >> convenience.
> > > >>
> > > >> Source and binary files:
> > > >>
> > > >>
> > >
> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
> > > >>
> > > >> SHA-512 checksums:
> > > >>
> > > >>
> > > >>
> > >
> 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950
> > > >>  apache-pulsar-client-cpp-3.4.0.tar.gz
> > > >>
> > > >>
> > > >> The tag to be voted upon:
> > > >> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70)
> > > >>
> > > >>
> > >
> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2
> > > >>
> > > >> Pulsar's KEYS file containing PGP keys you use to sign the release:
> > > >> https://downloads.apache.org/pulsar/KEYS
> > > >>
> > > >> Please download the source package, and follow the README to
> compile and
> > > >> test.
> > > >>
> > > >
> > >
>

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

Posted by Yunze Xu <xy...@apache.org>.
I think it's caused by the ClientTest.testConnectTimeout. The
resources seem not cleaned well in this test so it affected the tests
later. Could you try the following command that ignores this test?

```bash
./pulsar-tests  --gtest_filter='-ClientTest.testConnectTimeout'
```

If the rest of the tests pass, you can open an issue to track this
flaky test. And I see the local host is "198.18.0.1", did you use any
proxy when running the tests?


> Is it possible to install the CPP client without building from the source code?

Currently there is no "true" way to avoid building from source. You
can edit the libpulsar ruby file to install the 3.4.0-candidate-2 (See
https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md#to-contribute-a-fix-to-the-foo-formula)
but it still builds from source. The only advantage is that all 3rd
party dependencies are guaranteed to be installed from homebrew..
Maybe we can add a workflow to upload the pre-built libraries for
macOS in future.

----

BTW, I ran the `pulsar-tests` locally and it failed with two tests:

```
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] CustomLoggerTest.testCustomLogger
[  FAILED  ] LookupServiceTest.testMultiAddresses
```

These tests seem flaky so I reran them individually by:

```
./tests/pulsar-tests --gtest_filter='CustomLoggerTest.*'
./tests/pulsar-tests --gtest_filter='*testMultiAddresses'
```

`LookupServiceTest.testMultiAddresses` still failed. I will take a look soon.

Thanks,
Yunze


On Wed, Nov 8, 2023 at 11:07 PM PengHui Li <pe...@apache.org> wrote:
>
> Hi Yunze,
>
> I got an error when running the pulsar-tests (I tried multiple times, same
> error)
>
> ```
> 2023-11-08 22:56:43.676 INFO  [0x16db63000] ProducerImpl:216 |
> [persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1,
> ] Created producer on broker [[::1]:58479 -> [::1]:6650]
> 2023-11-08 22:56:43.693 INFO  [0x1f086e080] ProducerImpl:791 |
> [persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-0,
> standalone-0-635] Closing producer for topic
> persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-0
> 2023-11-08 22:56:43.693 INFO  [0x1f086e080] ProducerImpl:791 |
> [persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1,
> standalone-0-636] Closing producer for topic
> persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1
> 2023-11-08 22:56:43.693 INFO  [0x16db63000] ProducerImpl:755 |
> [persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-0,
> standalone-0-635] Closed producer 0
> 2023-11-08 22:56:43.693 INFO  [0x16db63000] ProducerImpl:755 |
> [persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1,
> standalone-0-636] Closed producer 1
> 2023-11-08 22:56:44.773 WARN  [0x16ba07000] ConnectionPool:91 | Deleting
> stale connection from pool for pulsar://192.0.2.1:1234-0 use_count: 1 @
> 0x13000ea00
> 2023-11-08 22:56:44.773 INFO  [0x16ba07000] ClientConnection:268 | [
> 198.18.0.1:58467 -> 192.0.2.1:1234] Destroyed connection to pulsar://
> 192.0.2.1:1234
> 2023-11-08 22:56:44.773 INFO  [0x16ba07000] ClientConnection:188 | [<none>
> -> pulsar://192.0.2.1:1234] Create ClientConnection, timeout=1000
> 2023-11-08 22:56:44.773 INFO  [0x16ba07000] ConnectionPool:109 | Created
> connection for pulsar://192.0.2.1:1234
> 2023-11-08 22:56:44.775 INFO  [0x16ba07000] ClientConnection:398 | [
> 198.18.0.1:58482 -> 192.0.2.1:1234] Connected to broker
> 2023-11-08 22:56:45.774 ERROR [0x16ba07000] ClientConnection:612 | [
> 198.18.0.1:58482 -> 192.0.2.1:1234] Connection was not established in 1000
> ms, close the socket
> 2023-11-08 22:56:45.775 INFO  [0x16ba07000] ClientConnection:1319 | [
> 198.18.0.1:58482 -> 192.0.2.1:1234] Connection disconnected (refCnt: 2)
> 2023-11-08 22:56:45.775 ERROR [0x16ba07000] ClientImpl:199 | Error
> Checking/Getting Partition Metadata while creating producer on
> persistent://public/default/test-connect-timeout -- TimeOut
> zsh: segmentation fault  ./pulsar-tests
> ```
>
> Reproduce steps:
>
> - Build from downloaded source code (passed)
> - Start pulsar service (./pulsar-test-service-start.sh)
> - Run the test(./pulsar-tests)
>
> Then, I got the above errors after a few minutes.
> I'm not sure it's just a test issue or not.
>
> One more question:
>
> Is it possible to install the CPP client without building from the source
> code?
> From
> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
> I can find the package for Linux and Windows. But no package for macOS.
>
> Regards,
> Penghui
>
> On Wed, Nov 8, 2023 at 10:45 PM Yubiao Feng
> <yu...@streamnative.io.invalid> wrote:
>
> > Hi all
> >
> > Sorry, I'll send another email explaining what tests were done.
> >
> > Please ignore the previous email.
> >
> > Thanks
> > Yubiao Feng
> >
> >
> > On Wed, Nov 8, 2023 at 11:48 AM Yubiao Feng <yu...@streamnative.io>
> > wrote:
> >
> > > +1 (no-binding)
> > >
> > > Thanks
> > > Yubiao Feng
> > >
> > > On Tue, Nov 7, 2023 at 3:03 PM Yunze Xu <xy...@apache.org> wrote:
> > >
> > >> This is the second release candidate for Apache Pulsar Client C++,
> > >> version 3.4.0.
> > >>
> > >> It fixes the following issues:
> > >> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1
> > >>
> > >> *** Please download, test and vote on this release. This vote will stay
> > >> open
> > >> for at least 72 hours ***
> > >>
> > >> Note that we are voting upon the source (tag), binaries are provided for
> > >> convenience.
> > >>
> > >> Source and binary files:
> > >>
> > >>
> > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
> > >>
> > >> SHA-512 checksums:
> > >>
> > >>
> > >>
> > 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950
> > >>  apache-pulsar-client-cpp-3.4.0.tar.gz
> > >>
> > >>
> > >> The tag to be voted upon:
> > >> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70)
> > >>
> > >>
> > https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2
> > >>
> > >> Pulsar's KEYS file containing PGP keys you use to sign the release:
> > >> https://downloads.apache.org/pulsar/KEYS
> > >>
> > >> Please download the source package, and follow the README to compile and
> > >> test.
> > >>
> > >
> >

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

Posted by PengHui Li <pe...@apache.org>.
Hi Yunze,

I got an error when running the pulsar-tests (I tried multiple times, same
error)

```
2023-11-08 22:56:43.676 INFO  [0x16db63000] ProducerImpl:216 |
[persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1,
] Created producer on broker [[::1]:58479 -> [::1]:6650]
2023-11-08 22:56:43.693 INFO  [0x1f086e080] ProducerImpl:791 |
[persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-0,
standalone-0-635] Closing producer for topic
persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-0
2023-11-08 22:56:43.693 INFO  [0x1f086e080] ProducerImpl:791 |
[persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1,
standalone-0-636] Closing producer for topic
persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1
2023-11-08 22:56:43.693 INFO  [0x16db63000] ProducerImpl:755 |
[persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-0,
standalone-0-635] Closed producer 0
2023-11-08 22:56:43.693 INFO  [0x16db63000] ProducerImpl:755 |
[persistent://public/default/testPartitionedConsumerUnexpectedAckTimeout1699455403-partition-1,
standalone-0-636] Closed producer 1
2023-11-08 22:56:44.773 WARN  [0x16ba07000] ConnectionPool:91 | Deleting
stale connection from pool for pulsar://192.0.2.1:1234-0 use_count: 1 @
0x13000ea00
2023-11-08 22:56:44.773 INFO  [0x16ba07000] ClientConnection:268 | [
198.18.0.1:58467 -> 192.0.2.1:1234] Destroyed connection to pulsar://
192.0.2.1:1234
2023-11-08 22:56:44.773 INFO  [0x16ba07000] ClientConnection:188 | [<none>
-> pulsar://192.0.2.1:1234] Create ClientConnection, timeout=1000
2023-11-08 22:56:44.773 INFO  [0x16ba07000] ConnectionPool:109 | Created
connection for pulsar://192.0.2.1:1234
2023-11-08 22:56:44.775 INFO  [0x16ba07000] ClientConnection:398 | [
198.18.0.1:58482 -> 192.0.2.1:1234] Connected to broker
2023-11-08 22:56:45.774 ERROR [0x16ba07000] ClientConnection:612 | [
198.18.0.1:58482 -> 192.0.2.1:1234] Connection was not established in 1000
ms, close the socket
2023-11-08 22:56:45.775 INFO  [0x16ba07000] ClientConnection:1319 | [
198.18.0.1:58482 -> 192.0.2.1:1234] Connection disconnected (refCnt: 2)
2023-11-08 22:56:45.775 ERROR [0x16ba07000] ClientImpl:199 | Error
Checking/Getting Partition Metadata while creating producer on
persistent://public/default/test-connect-timeout -- TimeOut
zsh: segmentation fault  ./pulsar-tests
```

Reproduce steps:

- Build from downloaded source code (passed)
- Start pulsar service (./pulsar-test-service-start.sh)
- Run the test(./pulsar-tests)

Then, I got the above errors after a few minutes.
I'm not sure it's just a test issue or not.

One more question:

Is it possible to install the CPP client without building from the source
code?
From
https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
I can find the package for Linux and Windows. But no package for macOS.

Regards,
Penghui

On Wed, Nov 8, 2023 at 10:45 PM Yubiao Feng
<yu...@streamnative.io.invalid> wrote:

> Hi all
>
> Sorry, I'll send another email explaining what tests were done.
>
> Please ignore the previous email.
>
> Thanks
> Yubiao Feng
>
>
> On Wed, Nov 8, 2023 at 11:48 AM Yubiao Feng <yu...@streamnative.io>
> wrote:
>
> > +1 (no-binding)
> >
> > Thanks
> > Yubiao Feng
> >
> > On Tue, Nov 7, 2023 at 3:03 PM Yunze Xu <xy...@apache.org> wrote:
> >
> >> This is the second release candidate for Apache Pulsar Client C++,
> >> version 3.4.0.
> >>
> >> It fixes the following issues:
> >> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1
> >>
> >> *** Please download, test and vote on this release. This vote will stay
> >> open
> >> for at least 72 hours ***
> >>
> >> Note that we are voting upon the source (tag), binaries are provided for
> >> convenience.
> >>
> >> Source and binary files:
> >>
> >>
> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
> >>
> >> SHA-512 checksums:
> >>
> >>
> >>
> 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950
> >>  apache-pulsar-client-cpp-3.4.0.tar.gz
> >>
> >>
> >> The tag to be voted upon:
> >> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70)
> >>
> >>
> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2
> >>
> >> Pulsar's KEYS file containing PGP keys you use to sign the release:
> >> https://downloads.apache.org/pulsar/KEYS
> >>
> >> Please download the source package, and follow the README to compile and
> >> test.
> >>
> >
>

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

Posted by Yubiao Feng <yu...@streamnative.io.INVALID>.
Hi all

Sorry, I'll send another email explaining what tests were done.

Please ignore the previous email.

Thanks
Yubiao Feng


On Wed, Nov 8, 2023 at 11:48 AM Yubiao Feng <yu...@streamnative.io>
wrote:

> +1 (no-binding)
>
> Thanks
> Yubiao Feng
>
> On Tue, Nov 7, 2023 at 3:03 PM Yunze Xu <xy...@apache.org> wrote:
>
>> This is the second release candidate for Apache Pulsar Client C++,
>> version 3.4.0.
>>
>> It fixes the following issues:
>> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1
>>
>> *** Please download, test and vote on this release. This vote will stay
>> open
>> for at least 72 hours ***
>>
>> Note that we are voting upon the source (tag), binaries are provided for
>> convenience.
>>
>> Source and binary files:
>>
>> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
>>
>> SHA-512 checksums:
>>
>>
>> 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950
>>  apache-pulsar-client-cpp-3.4.0.tar.gz
>>
>>
>> The tag to be voted upon:
>> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70)
>>
>> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2
>>
>> Pulsar's KEYS file containing PGP keys you use to sign the release:
>> https://downloads.apache.org/pulsar/KEYS
>>
>> Please download the source package, and follow the README to compile and
>> test.
>>
>

Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2

Posted by Yubiao Feng <yu...@streamnative.io.INVALID>.
+1 (no-binding)

Thanks
Yubiao Feng

On Tue, Nov 7, 2023 at 3:03 PM Yunze Xu <xy...@apache.org> wrote:

> This is the second release candidate for Apache Pulsar Client C++,
> version 3.4.0.
>
> It fixes the following issues:
> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1
>
> *** Please download, test and vote on this release. This vote will stay
> open
> for at least 72 hours ***
>
> Note that we are voting upon the source (tag), binaries are provided for
> convenience.
>
> Source and binary files:
>
> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/
>
> SHA-512 checksums:
>
>
> 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950
>  apache-pulsar-client-cpp-3.4.0.tar.gz
>
>
> The tag to be voted upon:
> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70)
> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2
>
> Pulsar's KEYS file containing PGP keys you use to sign the release:
> https://downloads.apache.org/pulsar/KEYS
>
> Please download the source package, and follow the README to compile and
> test.
>