You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/08/14 04:15:13 UTC

[GitHub] noahziheng commented on issue #2279: add log4j2 of issue 1713 by team8

noahziheng commented on issue #2279: add log4j2 of issue 1713 by team8
URL: https://github.com/apache/incubator-dubbo/pull/2279#issuecomment-412749918
 
 
   Log4j2LoggerAdapter has two problems:
    - Collection is useless.
    - `SetLevel` and `SetFile` isn't implement.
   
   I finished review on `file changed`:)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org