You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2020/10/30 14:56:00 UTC
[jira] [Commented] (PHOENIX-6086) Take a snapshot of all SYSTEM
tables before attempting to upgrade them
[ https://issues.apache.org/jira/browse/PHOENIX-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223687#comment-17223687 ]
Hadoop QA commented on PHOENIX-6086:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 43s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m 50s{color} | {color:blue} phoenix-core in master has 969 extant spotbugs warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 2s{color} | {color:red} phoenix-core: The patch generated 24 new + 3501 unchanged - 25 fixed = 3525 total (was 3526) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} spotbugs {color} | {color:red} 3m 35s{color} | {color:red} phoenix-core generated 7 new + 963 unchanged - 6 fixed = 970 total (was 969) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 95m 31s{color} | {color:red} phoenix-core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 22s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}126m 39s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.query.ConnectionQueryServicesImpl.upgradeSystemChildLink(PhoenixConnection, boolean, Map) may fail to clean up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:to clean up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:[line 3967] is not discharged |
| | org.apache.phoenix.query.ConnectionQueryServicesImpl.upgradeSystemSequence(PhoenixConnection, Map) may fail to clean up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:clean up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:[line 3985] is not discharged |
| | org.apache.phoenix.query.ConnectionQueryServicesImpl.upgradeSystemStats(PhoenixConnection, Map) may fail to clean up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:clean up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:[line 4056] is not discharged |
| | org.apache.phoenix.query.ConnectionQueryServicesImpl.upgradeSystemTask(PhoenixConnection, Map) may fail to clean up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:clean up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:[line 4096] is not discharged |
| | org.apache.phoenix.query.ConnectionQueryServicesImpl.upgradeSystemTask(PhoenixConnection, Map) may fail to close Statement At ConnectionQueryServicesImpl.java:close Statement At ConnectionQueryServicesImpl.java:[line 4119] |
| | org.apache.phoenix.query.ConnectionQueryServicesImpl.upgradeSystemTask(PhoenixConnection, Map) passes a nonconstant String to an execute or addBatch method on an SQL statement At ConnectionQueryServicesImpl.java:String to an execute or addBatch method on an SQL statement At ConnectionQueryServicesImpl.java:[line 4119] |
| | org.apache.phoenix.query.ConnectionQueryServicesImpl.upgradeSystemTables(String, Properties) makes inefficient use of keySet iterator instead of entrySet iterator At ConnectionQueryServicesImpl.java:of keySet iterator instead of entrySet iterator At ConnectionQueryServicesImpl.java:[line 3908] |
| Failed junit tests | phoenix.end2end.SystemTablesCreationOnConnectionIT |
| | phoenix.end2end.MigrateSystemTablesToSystemNamespaceIT |
| | phoenix.end2end.OrphanViewToolIT |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/134/artifact/patchprocess/Dockerfile |
| JIRA Issue | PHOENIX-6086 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13014424/PHOENIX-6086.master.000.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 2f7cbb255939 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / ff46e35 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/134/artifact/patchprocess/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/134/artifact/patchprocess/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/134/artifact/patchprocess/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/134/testReport/ |
| Max. process+thread count | 6895 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/134/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Take a snapshot of all SYSTEM tables before attempting to upgrade them
> ----------------------------------------------------------------------
>
> Key: PHOENIX-6086
> URL: https://issues.apache.org/jira/browse/PHOENIX-6086
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Viraj Jasani
> Priority: Critical
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6086.master.000.patch
>
>
> Currently we only take a snapshot of SYSTEM.CATALOG before attempting to upgrade it (see [this|https://github.com/apache/phoenix/blob/1922895dfe5960dc025709b04acfaf974d3959dc/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L3718]). From 4.15 onwards we also store critical metadata information in other SYSTEM tables like SYSTEM.CHILD_LINK, so it is beneficial to also snapshot those tables before upgrading them henceforth.
> We also currently don't take a snapshot of SYSTEM.CATALOG on receiving an [UpgradeRequiredException|https://github.com/apache/phoenix/blob/1922895dfe5960dc025709b04acfaf974d3959dc/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L3685-L3707] which we should do.
> In case of any errors during the upgrade, we restore SYSTEM.CATALOG from this snapshot and we should extend this to all tables. In cases where the table didn't exist before the upgrade, we need to ensure it is dropped so that a subsequent upgrade attempt can start afresh.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)