You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tiagobento (via GitHub)" <gi...@apache.org> on 2024/04/08 14:38:13 UTC
Re: [PR] kie-issues#965-2: Make sure `kie-tools` is using the latest timestamped SNAPSHOT from Kogito (999-20240407-SNAPSHOT) [incubator-kie-tools]
tiagobento commented on code in PR #2229:
URL: https://github.com/apache/incubator-kie-tools/pull/2229#discussion_r1555951946
##########
packages/stunner-editors/pom.xml:
##########
@@ -326,7 +326,7 @@
<version.zanata.plugin>2.3.0</version.zanata.plugin>
<!-- KIE Libraries -->
- <version.org.kie>999-20240331-SNAPSHOT</version.org.kie>
+ <version.org.kie>999-20240407-SNAPSHOT</version.org.kie>
Review Comment:
Can we start using the version from `build-env` here? Adding an `install.js` script etc.
##########
packages/kn-plugin-workflow/env/index.js:
##########
@@ -39,12 +39,12 @@ module.exports = composeEnv([require("@kie-tools/root-env/env")], {
},
KN_PLUGIN_WORKFLOW__devModeImage: {
name: "KN_PLUGIN_WORKFLOW__devModeImage",
- default: "quay.io/kiegroup/kogito-swf-devmode-nightly:main-2024-04-03",
+ default: "quay.io/kiegroup/kogito-swf-devmode-nightly:main-2024-04-05",
description: "SonataFlow dev mode image (used on cli run)",
},
KN_PLUGIN_WORKFLOW__kogitoVersion: {
name: "KN_PLUGIN_WORKFLOW__kogitoVersion",
- default: "999-20240331-SNAPSHOT",
+ default: "999-20240407-SNAPSHOT",
description: "Kogito version to be used when creating and converting to Quarkus Projects",
},
Review Comment:
I think we can remove this env and start using `kogitoRuntime.version` from root-env.. WDYT? cc @paulovmr @caponetto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org