You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/02/17 19:39:14 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4407: Removed
deprecated fields from /deliveryservice_stats responses in 2.x
ocket8888 opened a new pull request #4407: Removed deprecated fields from /deliveryservice_stats responses in 2.x
URL: https://github.com/apache/trafficcontrol/pull/4407
## What does this PR (Pull Request) do?
- [x] This PR is not related to any Issue
Removes the deprecated "source" and "version" fields from the `/deliveryservice_stats` endpoint's responses in API versions 2.0 and higher.
## Which Traffic Control components are affected by this PR?
- Traffic Ops
## What is the best way to verify this PR?
No integration tests because it requires a running Traffic Stats instance.
Start Traffic Ops and make a GET request to `/deliveryservice_stats` at API version 2.0, verify the deprecated fields no longer appear.
## The following criteria are ALL met by this PR
- [x] I have explained why tests are unnecessary
- [x] Documentation will be added by #4371
- [x] An update to CHANGELOG.md is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rawlinp commented on issue #4407: Removed
deprecated fields from /deliveryservice_stats responses in 2.x
Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #4407: Removed deprecated fields from /deliveryservice_stats responses in 2.x
URL: https://github.com/apache/trafficcontrol/pull/4407#issuecomment-588485997
CI failure appears to be unrelated to this PR, so merging anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mhoppa commented on issue #4407: Removed
deprecated fields from /deliveryservice_stats responses in 2.x
Posted by GitBox <gi...@apache.org>.
mhoppa commented on issue #4407: Removed deprecated fields from /deliveryservice_stats responses in 2.x
URL: https://github.com/apache/trafficcontrol/pull/4407#issuecomment-588475482
well in that case....lets merge this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on issue #4407: Removed
deprecated fields from /deliveryservice_stats responses in 2.x
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4407: Removed deprecated fields from /deliveryservice_stats responses in 2.x
URL: https://github.com/apache/trafficcontrol/pull/4407#issuecomment-588475129
I promise I'll do the docs changes either way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rawlinp merged pull request #4407: Removed
deprecated fields from /deliveryservice_stats responses in 2.x
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #4407: Removed deprecated fields from /deliveryservice_stats responses in 2.x
URL: https://github.com/apache/trafficcontrol/pull/4407
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services