[GitHub] [solr-sandbox] markrmiller commented on a diff in pull request #34: Config improvements and queue bug fixes.

[GitBox <gi...@apache.org>]

markrmiller commented on code in PR #34:
URL: https://github.com/apache/solr-sandbox/pull/34#discussion_r948344522


##########
crossdc-commons/src/main/java/org/apache/solr/crossdc/common/KafkaCrossDcConf.java:
##########
@@ -16,25 +16,49 @@
  */
 package org.apache.solr.crossdc.common;
 
+import org.apache.kafka.clients.producer.ProducerConfig;
+
 public class KafkaCrossDcConf extends CrossDcConf {
+
+    public static final String DEFAULT_BATCH_SIZE_BYTES = "512000";

Review Comment:
   Not necessarily, they are mainly String because there first use is as the default in System.getProperty,which takes a String. That doesn't use Integer.get to pull the property because Null is needed as the default instead of something like -1.
   
   In general it would be good to simplify this config into more útil code. It's a lot of effort to add one currently. I haven't wanted to do it as part of adding more yet though, probably better as a self contained issue. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org