You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kanna Karanam (JIRA)" <ji...@apache.org> on 2012/06/22 02:57:42 UTC
[jira] [Created] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Kanna Karanam created HIVE-3172:
-----------------------------------
Summary: Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Key: HIVE-3172
URL: https://issues.apache.org/jira/browse/HIVE-3172
Project: Hive
Issue Type: Sub-task
Components: Tests, Windows
Affects Versions: 0.10.0
Environment: Windows
Reporter: Kanna Karanam
Fix For: 0.10.0
The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
<!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
<fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
<fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
<fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
<fileset dir="${hive.root}/testlibs" includes="*.jar"/>
Proposed solution (workaround)–
1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400286#comment-13400286 ]
Carl Steinbach commented on HIVE-3172:
--------------------------------------
> All MiniMR cluster related test cases are failing when hadoop is attempting to run the MR jobs.
I'm kind of surprised that this isn't breaking all of the tests. Why does it only affect the Minimr tests? Specifically which parameter is too long? Can you please provide a reference to a class and method? Thanks.
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt, HIVE-3172.2.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400278#comment-13400278 ]
Kanna Karanam commented on HIVE-3172:
-------------------------------------
Updated the patch with missing files.
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt, HIVE-3172.2.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3172:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks, Kanna!
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt, HIVE-3172.2.patch.txt, HIVE-3172.3.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400291#comment-13400291 ]
Kanna Karanam commented on HIVE-3172:
-------------------------------------
@Carl - You are right. It has impact on all unit tests (Not just Minimr). Length of the %CLASSPATH% is almost ~14000 characters length with duplicate entries. It came down to ~ 6000 characters after removing the duplicate entries.
HIVE-3126 changes are required to run unit tests on Windows and HIVE-3126.1.patch.txt had a work around to that masked all other unit test failures. I removed that workaround in HIVE-3126.2.patch.txt
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt, HIVE-3172.2.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399154#comment-13399154 ]
Kanna Karanam commented on HIVE-3172:
-------------------------------------
@Carl – I was thinking of another easy and cleaner approach to solve this. If we can drop all jars to a single folder and refer that folder in the class path instead of multiple folders. Please let me know your opinion on this approach. Thanks
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3172:
--------------------------------
Attachment: HIVE-3172.3.patch.txt
Removed the unused imports from the previous patch.
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt, HIVE-3172.2.patch.txt, HIVE-3172.3.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3172:
--------------------------------
Attachment: HIVE-3172.1.patch.txt
Attached the patch.
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404340#comment-13404340 ]
Ashutosh Chauhan commented on HIVE-3172:
----------------------------------------
+1 will commit if tests pass.
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt, HIVE-3172.2.patch.txt, HIVE-3172.3.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3172:
-----------------------------------
Status: Open (was: Patch Available)
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3172:
-----------------------------------
Status: Open (was: Patch Available)
Hi Kanna,
I left some review comments on Review Board. Thanks!
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt, HIVE-3172.2.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400073#comment-13400073 ]
Kanna Karanam commented on HIVE-3172:
-------------------------------------
Extended the ANT path class to remove the duplicate JAR entries from the original class path.
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3172:
-----------------------------------
Status: Patch Available (was: Open)
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt, HIVE-3172.2.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3172:
--------------------------------
Status: Patch Available (was: Open)
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt, HIVE-3172.2.patch.txt, HIVE-3172.3.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400279#comment-13400279 ]
Kanna Karanam commented on HIVE-3172:
-------------------------------------
code review request is available at https://reviews.apache.org/r/5541/
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt, HIVE-3172.2.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404898#comment-13404898 ]
Hudson commented on HIVE-3172:
------------------------------
Integrated in Hive-trunk-h0.21 #1522 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1522/])
HIVE-3172 : Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows (Kanna Karanam via Ashutosh Chauhan) (Revision 1356035)
Result = FAILURE
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356035
Files :
* /hive/trunk/ant/src/org/apache/hadoop/hive/ant/DistinctElementsClassPath.java
* /hive/trunk/build-common.xml
* /hive/trunk/jdbc/build.xml
* /hive/trunk/odbc/build.xml
* /hive/trunk/shims/build.xml
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt, HIVE-3172.2.patch.txt, HIVE-3172.3.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399060#comment-13399060 ]
Carl Steinbach commented on HIVE-3172:
--------------------------------------
bq. Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
How are you planning to do this?
Also, which command is failing because of the DOS string length limit?
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399067#comment-13399067 ]
Kanna Karanam commented on HIVE-3172:
-------------------------------------
@Carl - All MiniMR cluster related test cases are failing when hadoop is attempting to run the MR jobs.
I am debating on following two approaches-.
1) Create a custom ANT task that takes the list of folders/filesets as an input and enumerates files from each folder and adds to list/classpath if doesn’t exist already. (Based on unique names). I have very limited knowledge on ANT so please let me know if you see any error.
2) Hacky solution is replace the fileset with path element in the test class path.
Please let me know if you see any other possible solutions.
Thanks
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3172:
-----------------------------------
Assignee: Kanna Karanam
Status: Patch Available (was: Open)
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3172) Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3172:
--------------------------------
Attachment: HIVE-3172.2.patch.txt
> Remove the duplicate JAR entries from the (“test.classpath”) to avoid command line exceeding char limit on windows
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-3172
> URL: https://issues.apache.org/jira/browse/HIVE-3172
> Project: Hive
> Issue Type: Sub-task
> Components: Tests, Windows
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0
>
> Attachments: HIVE-3172.1.patch.txt, HIVE-3172.2.patch.txt
>
>
> The maximum length of the DOS command string is 8191 characters (in Windows latest versions http://support.microsoft.com/kb/830473). Following entries in the “build-common.xml” are adding lot of duplicate JAR entries to the “test.classpath” and it exceeds the max character limit on windows very easily.
> <!-- Include build/dist/lib on the classpath before Ivy and exclude hive jars from Ivy to make sure we get the local changes when we test Hive -->
> <fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/test" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar"/>
> <fileset dir="${hive.root}/build/ivy/lib/default" includes="*.jar" erroronmissingdir="false" excludes="**/hive_*.jar,**/hive-*.jar" />
> <fileset dir="${hive.root}/testlibs" includes="*.jar"/>
> Proposed solution (workaround)–
> 1)Include all JARs from dist\lib excluding "**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"
> 2)Select the specific jars (missing jars) from test/other folders, (that includes Hadoop-*.jar files)
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira