You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Lars Francke <as...@lars-francke.de> on 2020/01/21 10:39:35 UTC

Review Request 72031: RANGER-2707 ranger.usersync.enabled not respected on initial ugsync startup

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72031/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-2707
    https://issues.apache.org/jira/browse/RANGER-2707


Repository: ranger


Description
-------

ranger.usersync.enabled can be used to control whether usersync is enabled or not.

Unfortunately UserGroupSync unconditionally does run a sync when it initially starts no matter what this setting is set to.

This is annoying if Ambari automatically starts usersync


I took this opportunity to clean up the UGSync class a bit


Diffs
-----

  ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSync.java 2befe33ea 


Diff: https://reviews.apache.org/r/72031/diff/1/


Testing
-------


Thanks,

Lars Francke


Re: Review Request 72031: RANGER-2707 ranger.usersync.enabled not respected on initial ugsync startup

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72031/#review219633
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On Jan. 21, 2020, 10:39 a.m., Lars Francke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72031/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2020, 10:39 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2707
>     https://issues.apache.org/jira/browse/RANGER-2707
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> ranger.usersync.enabled can be used to control whether usersync is enabled or not.
> 
> Unfortunately UserGroupSync unconditionally does run a sync when it initially starts no matter what this setting is set to.
> 
> This is annoying if Ambari automatically starts usersync
> 
> 
> I took this opportunity to clean up the UGSync class a bit
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSync.java 2befe33ea 
> 
> 
> Diff: https://reviews.apache.org/r/72031/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lars Francke
> 
>