[GitHub] [doris] Gabriel39 commented on a diff in pull request #12984: [feature-wip](parquet-reader) bugfix, VFileScanner has memory leakage when ParquetReader init failed

[GitBox <gi...@apache.org>]

Gabriel39 commented on code in PR #12984:
URL: https://github.com/apache/doris/pull/12984#discussion_r980061621


##########
be/src/vec/exec/scan/vfile_scanner.cpp:
##########
@@ -336,12 +336,13 @@ Status VFileScanner::_get_next_reader() {
             for (int i = 0; i < _file_slot_descs.size(); i++) {
                 column_names.push_back(_file_slot_descs[i]->col_name());
             }
-            _cur_reader = new ParquetReader(_profile, _params, range, column_names,

Review Comment:
   I think we should not use `_cur_reader` as a pure pointer. Maybe we can resolve this issue by changing this to a unique pointer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org