You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/07 12:28:28 UTC
[GitHub] [calcite] danny0405 opened a new pull request #1729: [CALCITE-3715]
Add an interface to pass the table hints to RelOptTable
danny0405 opened a new pull request #1729: [CALCITE-3715] Add an interface to pass the table hints to RelOptTable
URL: https://github.com/apache/calcite/pull/1729
* In RelOptTable, add an interface ToRelContextSupplier to allow
customize the ToRelContext
* Add ToRelContext#getTableHints to fetch hints when translating table
to relational node
* Add a new method ViewExpanders#toRelContext(ViewExpander,
RelOptCluster, List<RelHint>) to allow passing the hints to the ToRelContext
* Remove the old `viewExpander instanceOf ToRelContext` logic because it
is never used in Calcite, and we should not cast a superclass to child
class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] vlsi commented on issue #1729: [CALCITE-3715] Add an
interface to pass the table hints to RelOptTable
Posted by GitBox <gi...@apache.org>.
vlsi commented on issue #1729: [CALCITE-3715] Add an interface to pass the table hints to RelOptTable
URL: https://github.com/apache/calcite/pull/1729#issuecomment-571605603
@danny0405 , just wondering: is it something that would enable us to specify `use_hash(emp, dept)`-like hints?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 merged pull request #1729: [CALCITE-3715] Add
an interface to pass the table hints to RelOptTable
Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #1729: [CALCITE-3715] Add an interface to pass the table hints to RelOptTable
URL: https://github.com/apache/calcite/pull/1729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 commented on a change in pull request #1729:
[CALCITE-3715] Add an interface to pass the table hints to RelOptTable
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #1729: [CALCITE-3715] Add an interface to pass the table hints to RelOptTable
URL: https://github.com/apache/calcite/pull/1729#discussion_r364059684
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptTable.java
##########
@@ -150,5 +151,29 @@ RelRoot expandView(RelDataType rowType, String queryString,
* expression. */
interface ToRelContext extends ViewExpander {
RelOptCluster getCluster();
+
+ /**
+ * Returns the table hints of the table to convert,
+ * usually you can use the hints to pass along some dynamic params.
Review comment:
Agree, thanks for the nice review ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 commented on issue #1729: [CALCITE-3715] Add an
interface to pass the table hints to RelOptTable
Posted by GitBox <gi...@apache.org>.
danny0405 commented on issue #1729: [CALCITE-3715] Add an interface to pass the table hints to RelOptTable
URL: https://github.com/apache/calcite/pull/1729#issuecomment-571852866
> @danny0405 , just wondering: is it something that would enable us to specify `use_hash(emp, dept)`-like hints?
Yes, we have supported hints syntax like that, but this PR only takes the table hints into account.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] cshuo commented on a change in pull request #1729:
[CALCITE-3715] Add an interface to pass the table hints to RelOptTable
Posted by GitBox <gi...@apache.org>.
cshuo commented on a change in pull request #1729: [CALCITE-3715] Add an interface to pass the table hints to RelOptTable
URL: https://github.com/apache/calcite/pull/1729#discussion_r364057758
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptTable.java
##########
@@ -150,5 +151,29 @@ RelRoot expandView(RelDataType rowType, String queryString,
* expression. */
interface ToRelContext extends ViewExpander {
RelOptCluster getCluster();
+
+ /**
+ * Returns the table hints of the table to convert,
+ * usually you can use the hints to pass along some dynamic params.
Review comment:
`params` -> `properties` better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services