You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/06 19:04:58 UTC
[GitHub] [druid] mgill25 opened a new pull request #9325: Use
ExecutorService instead of ScheduledExecutorService where necessary
mgill25 opened a new pull request #9325: Use ExecutorService instead of ScheduledExecutorService where necessary
URL: https://github.com/apache/druid/pull/9325
Fixes #9286
### Description
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
Changed the two instances mentioned in the PR to use `Execs.singleThreaded`, which returns an `ExecutorService`, instead of a `ScheduledExecutorService`.
I looked at the concurrency checklist (Threads and Executors section), but don't see anything immediate that I also need to do. Please correct me if I missed something.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
<hr>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] mgill25 opened a new pull request #9325: Use
ExecutorService instead of ScheduledExecutorService where necessary
Posted by GitBox <gi...@apache.org>.
mgill25 opened a new pull request #9325: Use ExecutorService instead of ScheduledExecutorService where necessary
URL: https://github.com/apache/druid/pull/9325
Fixes #9286
### Description
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
Changed the two instances mentioned in the PR to use `Execs.singleThreaded`, which returns an `ExecutorService`, instead of a `ScheduledExecutorService`.
I looked at the concurrency checklist (Threads and Executors section), but don't see anything immediate that I also need to do. Please correct me if I missed something.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
<hr>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] mgill25 closed pull request #9325: Use ExecutorService
instead of ScheduledExecutorService where necessary
Posted by GitBox <gi...@apache.org>.
mgill25 closed pull request #9325: Use ExecutorService instead of ScheduledExecutorService where necessary
URL: https://github.com/apache/druid/pull/9325
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on issue #9325: Use ExecutorService
instead of ScheduledExecutorService where necessary
Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9325: Use ExecutorService instead of ScheduledExecutorService where necessary
URL: https://github.com/apache/druid/pull/9325#issuecomment-584391262
Hi @mgill25, thank you for your contribution. The change looks good to me, but technically this PR doesn’t fix the issue #9286 because it is about prohibiting this pattern by adding a new inspection rule. Are you interested in adding such a rule? If so please include the new rule in the PR. If not, please update the PR description to not include “Fixes #9286”.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] mgill25 commented on issue #9325: Use ExecutorService
instead of ScheduledExecutorService where necessary
Posted by GitBox <gi...@apache.org>.
mgill25 commented on issue #9325: Use ExecutorService instead of ScheduledExecutorService where necessary
URL: https://github.com/apache/druid/pull/9325#issuecomment-584896066
@jihoonson My bad, I'm not too familiar with IntelliJ inspection, so I guess I missed it. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #9325: Use ExecutorService
instead of ScheduledExecutorService where necessary
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #9325: Use ExecutorService instead of ScheduledExecutorService where necessary
URL: https://github.com/apache/druid/pull/9325
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org