[jira] [Commented] (FLINK-9323) Move checkstyle configuration to plugin management

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468732#comment-16468732 ] 

ASF GitHub Bot commented on FLINK-9323:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5972

    [FLINK-9323][build] Properly organize checkstyle-plugin configuration

    ## What is the purpose of the change
    
    This PR reorganizes the checkstyle-plugin configuration to not be duplicated in 4 modules. Instead the configuration was moved into the root pluginManagement section. The child poms were adjusted to only override settings if required.
    
    ## Brief change log
    
    * move checkstyle configuration into root pluginManagement section
    * reduce child pom configuration to essential entry
    
    ## Verifying this change
    
    * run `mvn help:effective-pom` to verify that the effective poms have not changed, and that the suppression file is properly overridden


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 9323

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5972.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5972
    
----
commit 7ac435e9240d14d6f264bdba205adfd6394005f3
Author: zentol <ch...@...>
Date:   2018-05-09T11:20:41Z

    [FLINK-9323][build] Properly organize checkstyle-plugin configuration

----


> Move checkstyle configuration to plugin management
> --------------------------------------------------
>
>                 Key: FLINK-9323
>                 URL: https://issues.apache.org/jira/browse/FLINK-9323
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> The checkstyle plugin configuration is currently duplicated in 4 modules. We should instead move the configuration into the plugin-management section.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)