You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Tao Feng <fe...@gmail.com> on 2015/12/14 22:04:54 UTC
Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not
handled correctly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41365/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
rocskdb ttl is handled per RocksDB semantics(https://github.com/facebook/rocksdb/wiki/Time-to-Live) which zero or negative ttl is same as infinity ttl.
Diffs
-----
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 211fc3be1e168f1f92812406785b39b5a3fd9174
Diff: https://reviews.apache.org/r/41365/diff/
Testing
-------
./gradlew clean build && ./gradlew checkstyleMain checkstyleTest
Thanks,
Tao Feng
Re: Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not
handled correctly
Posted by Boris Shkolnik <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41365/#review110854
-----------------------------------------------------------
Ship it!
Ship It!
- Boris Shkolnik
On Dec. 15, 2015, 11:58 p.m., Tao Feng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41365/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 11:58 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> update per Navina's comment
>
>
> Diffs
> -----
>
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 211fc3be1e168f1f92812406785b39b5a3fd9174
>
> Diff: https://reviews.apache.org/r/41365/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build && ./gradlew checkstyleMain checkstyleTest
>
>
> Thanks,
>
> Tao Feng
>
>
Re: Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not
handled correctly
Posted by Tao Feng <fe...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41365/
-----------------------------------------------------------
(Updated Dec. 15, 2015, 11:58 p.m.)
Review request for samza.
Repository: samza
Description (updated)
-------
update per Navina's comment
Diffs (updated)
-----
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 211fc3be1e168f1f92812406785b39b5a3fd9174
Diff: https://reviews.apache.org/r/41365/diff/
Testing
-------
./gradlew clean build && ./gradlew checkstyleMain checkstyleTest
Thanks,
Tao Feng
Re: Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not
handled correctly
Posted by Tao Feng <fe...@gmail.com>.
> On Dec. 15, 2015, 7:59 p.m., Navina Ramesh wrote:
> > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala, line 54
> > <https://reviews.apache.org/r/41365/diff/1/?file=1163801#file1163801line54>
> >
> > I don't think mentioning RocksDB wiki is necessary. You can change it to:
> > "Non-positive TTL for RocksDB implies infinite TTL for the data."
Thanks Navina for the suggestion. I will update the rb.
- Tao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41365/#review110553
-----------------------------------------------------------
On Dec. 14, 2015, 9:04 p.m., Tao Feng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41365/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 9:04 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> rocskdb ttl is handled per RocksDB semantics(https://github.com/facebook/rocksdb/wiki/Time-to-Live) which zero or negative ttl is same as infinity ttl.
>
>
> Diffs
> -----
>
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 211fc3be1e168f1f92812406785b39b5a3fd9174
>
> Diff: https://reviews.apache.org/r/41365/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build && ./gradlew checkstyleMain checkstyleTest
>
>
> Thanks,
>
> Tao Feng
>
>
Re: Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not
handled correctly
Posted by Navina Ramesh <nr...@linkedin.com>.
> On Dec. 15, 2015, 7:59 p.m., Navina Ramesh wrote:
> > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala, line 54
> > <https://reviews.apache.org/r/41365/diff/1/?file=1163801#file1163801line54>
> >
> > I don't think mentioning RocksDB wiki is necessary. You can change it to:
> > "Non-positive TTL for RocksDB implies infinite TTL for the data."
>
> Tao Feng wrote:
> Thanks Navina for the suggestion. I will update the rb.
You can optionally provide the link - https://github.com/facebook/rocksdb/wiki/Time-to-Live in the log statement
- Navina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41365/#review110553
-----------------------------------------------------------
On Dec. 15, 2015, 11:58 p.m., Tao Feng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41365/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 11:58 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> update per Navina's comment
>
>
> Diffs
> -----
>
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 211fc3be1e168f1f92812406785b39b5a3fd9174
>
> Diff: https://reviews.apache.org/r/41365/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build && ./gradlew checkstyleMain checkstyleTest
>
>
> Thanks,
>
> Tao Feng
>
>
Re: Review Request 41365: SAMZA-838: negative rocksdb.ttl.ms is not
handled correctly
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41365/#review110553
-----------------------------------------------------------
Ship it!
One nit. Otherwise, looks good!
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala (line 54)
<https://reviews.apache.org/r/41365/#comment170489>
I don't think mentioning RocksDB wiki is necessary. You can change it to:
"Non-positive TTL for RocksDB implies infinite TTL for the data."
- Navina Ramesh
On Dec. 14, 2015, 9:04 p.m., Tao Feng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41365/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 9:04 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> rocskdb ttl is handled per RocksDB semantics(https://github.com/facebook/rocksdb/wiki/Time-to-Live) which zero or negative ttl is same as infinity ttl.
>
>
> Diffs
> -----
>
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 211fc3be1e168f1f92812406785b39b5a3fd9174
>
> Diff: https://reviews.apache.org/r/41365/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build && ./gradlew checkstyleMain checkstyleTest
>
>
> Thanks,
>
> Tao Feng
>
>