You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Sunil G (JIRA)" <ji...@apache.org> on 2017/02/07 16:42:41 UTC
[jira] [Comment Edited] (YARN-5956) Refactor ClientRMService
[ https://issues.apache.org/jira/browse/YARN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856302#comment-15856302 ]
Sunil G edited comment on YARN-5956 at 2/7/17 4:41 PM:
-------------------------------------------------------
HI [~kaisasak]
Thanks for the patch. I have some doubts in this patch. {{GetApplicationReportResponse getApplicationReport}} is now invoking {{getCallerUgi}} and {{verifyUserAccessForRMApp}}. Internally {{verifyUserAccessForRMApp}} is already doing {{checkAccess}} check. But its still invoked from *getApplicationReport*.
I think same comment applies to few more apis as well. Could you please check the same.
was (Author: sunilg):
HI [~kaisasak]
Thanks for the patch. I have some doubts in this patch. {{GetApplicationReportResponse getApplicationReport}} is now invoking {{getCallerUgi} } and {{verifyUserAccessForRMApp}}. Internally {{verifyUserAccessForRMApp}} is already doing {{checkAccess}} check. But its still invoked from *getApplicationReport*.
I think same comment applies to few more apis as well. Could you please check the same.
> Refactor ClientRMService
> ------------------------
>
> Key: YARN-5956
> URL: https://issues.apache.org/jira/browse/YARN-5956
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 3.0.0-alpha2
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Priority: Minor
> Attachments: YARN-5956.01.patch, YARN-5956.02.patch, YARN-5956.03.patch, YARN-5956.04.patch, YARN-5956.05.patch, YARN-5956.06.patch, YARN-5956.07.patch, YARN-5956.08.patch
>
>
> Some refactoring can be done in {{ClientRMService}}.
> - Remove redundant variable declaration
> - Fill in missing javadocs
> - Proper variable access modifier
> - Fix some typos in method name and exception messages
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org