You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/10/25 02:13:17 UTC
[kudu-CR] block manager: disk space checking everywhere
Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4832
to review the following change.
Change subject: block_manager: disk space checking everywhere
......................................................................
block_manager: disk space checking everywhere
This patch extends the disk space checking feature to the file block manager
and to the log block manager without preallocation. Neither of these are
hotly requested, but it's easy to do and it removes all conditions from the
help text, so I think it's a net benefit.
Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
5 files changed, 48 insertions(+), 60 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/4832/1
--
To view, visit http://gerrit.cloudera.org:8080/4832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] block manager: disk space checking everywhere
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4832
to look at the new patch set (#4).
Change subject: block_manager: disk space checking everywhere
......................................................................
block_manager: disk space checking everywhere
This patch extends the disk space checking feature to the file block manager
and to the log block manager without preallocation. Neither of these are
hotly requested, but it's easy to do and it removes all conditions from the
help text, so I think it's a net benefit.
Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
5 files changed, 52 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/4832/4
--
To view, visit http://gerrit.cloudera.org:8080/4832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] block manager: disk space checking everywhere
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: block_manager: disk space checking everywhere
......................................................................
Patch Set 5:
Apparently needs a rebase, please feel free to carry my +2 through
--
To view, visit http://gerrit.cloudera.org:8080/4832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] block manager: disk space checking everywhere
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: block_manager: disk space checking everywhere
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] block manager: disk space checking everywhere
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4832
to look at the new patch set (#2).
Change subject: block_manager: disk space checking everywhere
......................................................................
block_manager: disk space checking everywhere
This patch extends the disk space checking feature to the file block manager
and to the log block manager without preallocation. Neither of these are
hotly requested, but it's easy to do and it removes all conditions from the
help text, so I think it's a net benefit.
Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
5 files changed, 49 insertions(+), 60 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/4832/2
--
To view, visit http://gerrit.cloudera.org:8080/4832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] block manager: disk space checking everywhere
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4832
to look at the new patch set (#3).
Change subject: block_manager: disk space checking everywhere
......................................................................
block_manager: disk space checking everywhere
This patch extends the disk space checking feature to the file block manager
and to the log block manager without preallocation. Neither of these are
hotly requested, but it's easy to do and it removes all conditions from the
help text, so I think it's a net benefit.
Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
5 files changed, 52 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/4832/3
--
To view, visit http://gerrit.cloudera.org:8080/4832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] block manager: disk space checking everywhere
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: block_manager: disk space checking everywhere
......................................................................
block_manager: disk space checking everywhere
This patch extends the disk space checking feature to the file block manager
and to the log block manager without preallocation. Neither of these are
hotly requested, but it's easy to do and it removes all conditions from the
help text, so I think it's a net benefit.
Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
Reviewed-on: http://gerrit.cloudera.org:8080/4832
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
5 files changed, 52 insertions(+), 63 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] block manager: disk space checking everywhere
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: block_manager: disk space checking everywhere
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbce30d7fa981255949ade23373c13939b1e3d43
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No