Re: Review Request 19616: Added check for null return.

[Alex Hitchins <al...@shapeblue.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19616/
-----------------------------------------------------------

(Updated July 1, 2014, 3:29 p.m.)


Review request for cloudstack.


Changes
-------

not discarding as you might want to fix it yet. please consider discarding yourself.


Repository: cloudstack-git


Description
-------

Added check for returned null, if received then throw exception.

Amendments made as per dev mailing list comments.


Diffs
-----

  server/src/com/cloud/storage/VolumeApiServiceImpl.java 680cd2e 

Diff: https://reviews.apache.org/r/19616/diff/


Testing
-------

Compiled & ran.


Thanks,

Alex Hitchins

Re: Review Request 19616: Added check for null return.

[Sebastien Goasguen <ru...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19616/#review79042
-----------------------------------------------------------


Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.

We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).

Please consider submitting a pull request.

Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md

Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.

- Sebastien Goasguen


On July 1, 2014, 3:29 p.m., Alex Hitchins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19616/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 3:29 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added check for returned null, if received then throw exception.
> 
> Amendments made as per dev mailing list comments.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java 680cd2e 
> 
> Diff: https://reviews.apache.org/r/19616/diff/
> 
> 
> Testing
> -------
> 
> Compiled & ran.
> 
> 
> Thanks,
> 
> Alex Hitchins
> 
>