[GitHub] [incubator-doris] morningman commented on a change in pull request #2127: Support aggregation type of REPLACE_IF_NOT_NULL

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #2127: Support aggregation type of REPLACE_IF_NOT_NULL
URL: https://github.com/apache/incubator-doris/pull/2127#discussion_r342454991
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/ColumnDef.java
 ##########
 @@ -156,6 +156,15 @@ public void analyze(boolean isOlap) throws AnalysisException {
             defaultValue = DefaultValue.HLL_EMPTY_DEFAULT_VALUE;
         }
 
+        // If aggregate type is REPLACE_IF_NOT_NULL, we set it nullable.
+        // If defalut value is not se, we set it NULL
 
 Review comment:
   ```suggestion
           // If defalut value is not set, we set it NULL
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org