You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2009/08/03 01:29:37 UTC

svn commit: r800159 - in /hadoop/hbase/branches/0.20: CHANGES.txt src/java/org/apache/hadoop/hbase/ipc/HBaseClient.java

Author: stack
Date: Sun Aug  2 23:29:37 2009
New Revision: 800159

URL: http://svn.apache.org/viewvc?rev=800159&view=rev
Log:
HBASE-1604 HBaseClient.getConnection() may return a broken connection without throwing an exception

Modified:
    hadoop/hbase/branches/0.20/CHANGES.txt
    hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/ipc/HBaseClient.java

Modified: hadoop/hbase/branches/0.20/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/CHANGES.txt?rev=800159&r1=800158&r2=800159&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/CHANGES.txt (original)
+++ hadoop/hbase/branches/0.20/CHANGES.txt Sun Aug  2 23:29:37 2009
@@ -310,6 +310,8 @@
    HBASE-1725  Old TableMap interface's definitions are not generic enough
                (Doğacan Güney via Stack)
    HBASE-1732  Flag to disable regionserver restart
+   HBASE-1604  HBaseClient.getConnection() may return a broken connection
+               without throwing an exception (Eugene Kirpichov via Stack)
 
   IMPROVEMENTS
    HBASE-1089  Add count of regions on filesystem to master UI; add percentage

Modified: hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/ipc/HBaseClient.java?rev=800159&r1=800158&r2=800159&view=diff
==============================================================================
--- hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/ipc/HBaseClient.java (original)
+++ hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/ipc/HBaseClient.java Sun Aug  2 23:29:37 2009
@@ -286,7 +286,7 @@
      * a header to the server and starts
      * the connection thread that waits for responses.
      */
-    protected synchronized void setupIOstreams() {
+    protected synchronized void setupIOstreams() throws IOException {
       if (socket != null || shouldCloseConnection.get()) {
         return;
       }
@@ -328,6 +328,8 @@
       } catch (IOException e) {
         markClosed(e);
         close();
+
+        throw e;
       }
     }