You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/05/08 03:33:58 UTC
[GitHub] [hadoop] ashutoshcipher opened a new pull request, #4284: YARN-11135. Optimize Imports in hadoop project
ashutoshcipher opened a new pull request, #4284:
URL: https://github.com/apache/hadoop/pull/4284
### Description of PR
Optimize Imports in hadoop project
* JIRA: YARN-11135
- [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #4284: YARN-11135. Optimize Imports in hadoop project
Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #4284:
URL: https://github.com/apache/hadoop/pull/4284#issuecomment-1120938219
-1. wontfix.
if this were to go in
* every pending PR would no longer apply without rebasing/reworking
* every subsequent pr would be impossible to backport without reversing the work
we have a fraction of this problem even with the movement of unshaded guava to shaded guava to hadoop's own Precondition classes; moving things from trunk to 3.3. to internal PRs always fail to merge at those two or three imports.
we couldn't cope with this at scale.
this is also why we don't go overboard in reordering imports in the files touched within a normal PR: IDEs may think they are being helpful by cleaning up imports, but aren't. Removing unused imports is fine, but big cleanups, tht causes too many problems.
Sorry. if you had to deal with backporting you'd understand why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #4284: YARN-11135. Remove unused Imports in hadoop project
Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #4284:
URL: https://github.com/apache/hadoop/pull/4284#issuecomment-1123434514
ok. for tools/ do one for the different submodules, that way backporting is a lot easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher closed pull request #4284: YARN-11135. Remove unused Imports in hadoop project
Posted by GitBox <gi...@apache.org>.
ashutoshcipher closed pull request #4284: YARN-11135. Remove unused Imports in hadoop project
URL: https://github.com/apache/hadoop/pull/4284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on pull request #4284: YARN-11135. Remove unused Imports in hadoop project
Posted by GitBox <gi...@apache.org>.
ashutoshcipher commented on PR #4284:
URL: https://github.com/apache/hadoop/pull/4284#issuecomment-1123463314
Thanks @steveloughran. I have started with Hadoop Map/Reduce. Here is the PR of that. https://github.com/apache/hadoop/pull/4299. Can you please review? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on pull request #4284: YARN-11135. Optimize Imports in hadoop project
Posted by GitBox <gi...@apache.org>.
ashutoshcipher commented on PR #4284:
URL: https://github.com/apache/hadoop/pull/4284#issuecomment-1120343993
@aajisaka - Can you please have a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher closed pull request #4284: YARN-11135. Optimize Imports in hadoop project
Posted by GitBox <gi...@apache.org>.
ashutoshcipher closed pull request #4284: YARN-11135. Optimize Imports in hadoop project
URL: https://github.com/apache/hadoop/pull/4284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on pull request #4284: YARN-11135. Optimize Imports in hadoop project
Posted by GitBox <gi...@apache.org>.
ashutoshcipher commented on PR #4284:
URL: https://github.com/apache/hadoop/pull/4284#issuecomment-1121369104
@steveloughran - What you are saying makes sense. But let's do some clean up the code. I am changing the scope and only removing the unused imports. What do you think about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on pull request #4284: YARN-11135. Remove unused Imports in hadoop project
Posted by GitBox <gi...@apache.org>.
ashutoshcipher commented on PR #4284:
URL: https://github.com/apache/hadoop/pull/4284#issuecomment-1123078543
Closing this PR as discussed offline with @aajisaka. Will create separate JIRA and PR for each Hadoop project and reduce the scope to only remove unused imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org