You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/03 11:07:31 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #17391: More touches on `dag_maker` fixture to create DagModel automatically
ephraimbuddy opened a new pull request #17391:
URL: https://github.com/apache/airflow/pull/17391
This change improves the dag_maker fixture to create DagModel on exit
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #17391: More touches on `dag_maker` fixture to create DagModel automatically
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #17391:
URL: https://github.com/apache/airflow/pull/17391#discussion_r681669038
##########
File path: tests/conftest.py
##########
@@ -436,25 +436,27 @@ def dag_maker(request):
DEFAULT_DATE = timezone.datetime(2016, 1, 1)
class DagFactory:
- def __enter__(self):
+ @provide_session
+ def __enter__(self, session=None):
self.dag.__enter__()
+ self.session = session
Review comment:
Now used it on `__call__`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #17391: More touches on `dag_maker` fixture to create DagModel automatically
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #17391:
URL: https://github.com/apache/airflow/pull/17391#discussion_r681664002
##########
File path: tests/conftest.py
##########
@@ -436,25 +436,27 @@ def dag_maker(request):
DEFAULT_DATE = timezone.datetime(2016, 1, 1)
class DagFactory:
- def __enter__(self):
+ @provide_session
+ def __enter__(self, session=None):
self.dag.__enter__()
+ self.session = session
Review comment:
If we're going to store a session, we should do it in `__call__`, not `__enter__`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17391: More touches on `dag_maker` fixture to create DagModel automatically
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17391:
URL: https://github.com/apache/airflow/pull/17391#issuecomment-891860163
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy merged pull request #17391: More touches on `dag_maker` fixture to create DagModel automatically
Posted by GitBox <gi...@apache.org>.
ephraimbuddy merged pull request #17391:
URL: https://github.com/apache/airflow/pull/17391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org